Skip to content

Unable to extract currency from excel formatted cells #53

Open

Description

When I have an excel file with some cells formatted with currency, the conversion does not include the currency label. It only seems to extract the value.

For example an excel file with the following:
Image

Returns:
'## Sheet1\n| Unnamed: 0 | Unnamed: 1 | Unnamed: 2 | Unnamed: 3 | Unnamed: 4 |\n| --- | --- | --- | --- | --- |\n| Item | Count | Cost | Weight | Total |\n| Breakfast | 20 | 5 | NaN | 100 |\n| Laptops | 5 | 1199 | NaN | 5995 |\n| Car tires | 8 | 199 | 150 kg | 1592 |\n| NaN | NaN | NaN | NaN | 7687 |'

currency_label_invoice.xlsx
currency_label_invoice_2.xlsx

Activity

  1. afourney commented on Dec 16, 2024

    @afourney
    Member

    Hmm, good catch. The type and formatting info are in the cell metadata which might not be considered when we load the table via pandas. I'll see if there's an alternative approach.

  2. added a commit that references this issue on Jul 14, 2025
    4f03eeb
  3. preetpatel26 commented on Jul 14, 2025

    @preetpatel26

    Adam Fourney (@afourney) Gagan Bansal (@gagb) I have created PR #1325 for this issue

  4. added a commit that references this issue on Mar 11, 2026
    0b27f28
  5. added a commit that references this issue on Mar 21, 2026
    7239c2c
  6. added 2 commits that reference this issue on Apr 14, 2026
    7d24e20
    5173dca
  7. added a commit that references this issue on May 30, 2026
    f303706
  8. aslamalkarywk7 commented on Sep 18, 2026

    @aslamalkarywk7

    Hi! I would like to take this on (it carries the open-for-contribution label). Plan: in XlsxConverter, overlay Excel number-format currency symbols onto values (pandas drops number_format), so currency-formatted cells render with their label, plus a regression test with an in-memory workbook. Thanks!

  9. aslamalkarywk7 commented on Sep 18, 2026

    @aslamalkarywk7

    Opened PR #2538 with the fix (currency-symbol overlay from number_format + regression tests). All green locally; pre-existing env failures unchanged. Happy to adjust the approach if you prefer a different rendering.

  10. added a commit that references this issue on Oct 5, 2026
    2fce07e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingopen for contributionInvites open-source developers to contribute to the project.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions