Repository navigation
deps(markitdown): relax magika pin to allow 1.x - #2720
Closed
OUAO-FRANK wants to merge 3 commits into
Closed
OUAO-FRANK wants to merge 3 commits into
OUAO-FRANK wants to merge 3 commits into
Conversation
Member
|
This seems sensible, but there are more changes in the PR than just the Magika dependency. Let me see what I can do to remove this pin. |
Member
|
Ok, I bumped the version as requested, without making other changes. Please re-open this with a more detailed explanation for the xlsx changes if you would like those merged too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markitdownpinsmagika~=0.6.1. Every magika 0.6.x release runsdotenv.load_dotenv(dotenv.find_dotenv())inmagika/__init__.pyat import time, andfind_dotenv()walks up from magika's ownsite-packagesdirectory — soimport markitdownsilently loads the first.envit finds above the environment intoos.environ. This leaks unrelated variables into a running server process, and can resurrect an environment setting the operator removed on purpose.magika removed the dotenv dependency in 1.0.2 (google/magika#1283, google/magika#1285), but the
~=0.6.1pin prevents markitdown users from receiving that fix.This relaxes the pin to
magika>=0.6.1,<2, which:.env,Testing
The
markitdowncode path uses onlymagika.Magika()andMagika().identify_stream(), both unchanged in 1.0.3. The dotenv import is confirmed absent frommagika/__init__.pyin 1.0.3.No other package in the repo pins magika directly (
packages/markitdown-mcp,markitdown-ocr,markitdown-sample-pluginall depend onmarkitdowntransitively), so this is the single constraint to relax.Breaking Changes
==0.6.xvia~=) is widened to<2.Checklist
.env-into-os.environimportAI disclosure: this change was produced with an AI/LLM coding assistant (deepseek-v4 family). I verified magika 1.0.3's API and the removed dotenv import locally, and will answer maintainer questions myself. No commit is attributed to AI.
Closes #2719