Repository navigation
Handle registry.json tool listing time-to-live and paging - #3780
Open
Alan Zimmer (alzimmermsft) wants to merge 6 commits into
Open
Alan Zimmer (alzimmermsft) wants to merge 6 commits into
Alan Zimmer (alzimmermsft) wants to merge 6 commits into
Conversation
Alan Zimmer (alzimmermsft)
requested review from
KarishmaGhiya,
Jair Myree (jairmyree),
msalaman,
Sai Koumudi Kaluvakolanu (saikoumudi),
Sandeep Sen (sandeep-sen),
Tom Meschter (tmeschter) and
Jeff Fisher (xirzec)
and
a lite review from Copilot
September 24, 2026 16:19
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved pagination and cache-timestamp issues can omit tools or cause stale and unnecessary refreshes.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
Adds TTL-aware caching and paginated remote tool discovery for MCP loaders.
Changes:
- Propagates remote tool-list TTLs.
- Refreshes expired tool caches.
- Adds pagination, TTL, and refresh tests plus a changelog entry.
| File | Description |
|---|---|
servers/Azure.Mcp.Server/changelog-entries/copilot-registry-tool-cache-ttl.yaml |
Documents the cache and pagination fix. |
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/ToolListCache.cs |
Centralizes paginated tool listing and TTL handling. |
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/SingleProxyToolLoader.cs |
Adds TTL-aware proxy tool refresh. |
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/ServerToolLoader.cs |
Adds TTL-aware server tool caching. |
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/RegistryToolLoader.cs |
Integrates registry refresh and pagination. |
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/ToolLoading/CompositeToolLoader.cs |
Applies aggregate cache TTL handling. |
core/Microsoft.Mcp.Core/src/Areas/Server/Commands/Runtime/McpRuntime.cs |
Propagates loader TTLs with defaults. |
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.Tests/Areas/Server/Helpers/MockMcpClientBuilder.cs |
Supports TTL-aware test clients. |
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.Tests/Areas/Server/Commands/ToolLoading/SingleProxyToolLoaderTests.cs |
Tests proxy cache behavior. |
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.Tests/Areas/Server/Commands/ToolLoading/ServerToolLoaderTests.cs |
Tests server cache behavior. |
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.Tests/Areas/Server/Commands/ToolLoading/RegistryToolLoaderTests.cs |
Tests registry refresh and pagination. |
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.Tests/Areas/Server/Commands/ToolLoading/CompositeToolLoaderTests.cs |
Tests aggregate TTL handling. |
core/Azure.Mcp.Core/tests/Azure.Mcp.Core.Tests/Areas/Server/Commands/Runtime/McpRuntimeTests.cs |
Tests runtime TTL propagation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does this PR do?
Adds support for handling
registry.jsonremote server time-to-live in response and pagination.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline