Skip to content

Cleanup a couple allow-list settings for appconfig, azure-openai, communication, and speech. - #3941

Open
Steven Vukelich (vukelich) wants to merge 4 commits into
mainfrom
users/vukelich/legacy-check-cleanup
Open

Steven Vukelich (vukelich) wants to merge 4 commits into
mainfrom
users/vukelich/legacy-check-cleanup

Conversation

@vukelich

Copy link
Copy Markdown
Member

What does this PR do?

Finalizes the setting for several data plane service endpoints to use the "new" subdomain checking algorithm, i.e., going from UseLegacyCheck: true to UseLegacyCheck: false in core/Microsoft.Mcp.Core/src/Helpers/EndpointValidator.AllowLists.cs. See the comments higher up in EndpointValidator.AllowLists.cs for what UseLegacyCheck means as well as EndpointValidator.cs for the impact on implementation.

Also continuing the small clearing out of the old Germany cloud entries since it's gone.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions (excluding Fabric MCP tools), ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@azure-pipelines

This comment was marked as resolved.

This comment was marked as resolved.

@vukelich

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

@vukelich

This comment was marked as resolved.

@azure-pipelines

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server tools-Communication tools for Azure communication services tools-FoundryExtensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants