Repository navigation
Cleanup a couple allow-list settings for appconfig, azure-openai, communication, and speech. - #3941
Open
Steven Vukelich (vukelich) wants to merge 4 commits into
Open
Steven Vukelich (vukelich) wants to merge 4 commits into
Steven Vukelich (vukelich) wants to merge 4 commits into
Conversation
…munication, and speech.
Steven Vukelich (vukelich)
requested review from
a team and
KarishmaGhiya
as code owners
October 14, 2026 01:50
Steven Vukelich (vukelich)
requested review from
JasonYeMSFT (JasonYeMSFT),
Larry Osterman (LarryOsterman),
Chidozie Ononiwu (chidozieononiwu),
Vinay Gera (g2vinay),
msalaman and
Sandeep Sen (sandeep-sen)
and
a balanced review from Copilot
October 14, 2026 01:50
This comment was marked as resolved.
This comment was marked as resolved.
Alan Zimmer (alzimmermsft)
approved these changes
Oct 14, 2026
Rick Winter (RickWinter)
approved these changes
Oct 14, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…munication, and speech.
…nup' into users/vukelich/legacy-check-cleanup
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finalizes the setting for several data plane service endpoints to use the "new" subdomain checking algorithm, i.e., going from
UseLegacyCheck: truetoUseLegacyCheck: falseincore/Microsoft.Mcp.Core/src/Helpers/EndpointValidator.AllowLists.cs. See the comments higher up inEndpointValidator.AllowLists.csfor whatUseLegacyCheckmeans as well asEndpointValidator.csfor the impact on implementation.Also continuing the small clearing out of the old Germany cloud entries since it's gone.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline