Repository navigation
Split disk --tags on commas, as documented - #3999
Open
Federico Laurianti (Laurianti) wants to merge 2 commits into
Open
Federico Laurianti (Laurianti) wants to merge 2 commits into
Federico Laurianti (Laurianti) wants to merge 2 commits into
Conversation
Federico Laurianti (Laurianti)
requested review from
a team,
Audrey Toney (audreyttt),
Vinay Gera (g2vinay) and
Haider Agha (haagha)
as code owners
October 19, 2026 19:53
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Thank you for your contribution Federico Laurianti (@Laurianti)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The command reference still prescribes space-separated tags, and the reported playback failures require refreshed recording assets.
2 open issues
What changed in this PR
Fixes #3998 by aligning Compute disk tag parsing with the documented comma-separated format and existing VM behavior.
Changes:
- Split disk create/update tags on commas and trim keys and values.
- Add request-level regression tests for both operations.
- Add a bug-fix changelog entry.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Compute/tests/Azure.Mcp.Tools.Compute.Tests/Disk/DiskTagsServiceTests.cs | Tests comma-separated tags with optional whitespace. |
| tools/Azure.Mcp.Tools.Compute/src/Services/ComputeService.cs | Corrects disk tag splitting and trimming. |
| servers/Azure.Mcp.Server/changelog-entries/1792436742310.yaml | Documents the parsing fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
compute disk createandcompute disk updatenow split--tagson commas and trim keys and values, as documented and ascompute vm updateandcompute vmss updatealready do. Before,env=prod,team=computebecame a single tag,env=prod,team=compute. The disk sections ofazmcp-commands.mdnow document comma-separated tags too.Added
DiskTagsServiceTests, which checks the tags sent for create and update withenv=prod,team=computeandenv=prod, team=compute. It fails without the fix.Recordings to refresh: three recorded tests captured the bug and no longer match in playback, because the request now has the right tags:
DiskCreate_WithLocationAndTags_CreatesWithPropertiesDiskUpdate_AddTags_UpdatesSuccessfullyDiskUpdate_CreateThenUpdateMultipleProperties_FullLifecycleThe other 40 recorded Compute tests pass in playback. I can't push to
Azure/azure-sdk-assets, so these recordings need to be re-recorded by the team.GitHub issue number?
Fixes #3998
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline