Repository navigation
fix(screenshot): support full-page SVG documents - #43972
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| }); | ||
| expect(screenshot).toMatchSnapshot('screenshot-grid-fullpage.png'); | ||
|
|
||
| server.setRoute('/full-page.svg', (request, response) => { |
There was a problem hiding this comment.
this should be a separate test because it tests a vastly different scenario
There was a problem hiding this comment.
Moved the standalone SVG scenario into its own issue-tagged test, SS-097, and restored SS-011 to its original HTML-only test. Both pass on all three browsers.
Revision run on Linux - workflow run
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
|
Hi, I'm the Playwright bot. I moved the SVG regression into its own issue-tagged test, SS-097, restored the existing HTML test, and updated the test registry. The HTML and SVG tests pass on Chromium, Firefox and WebKit. The SVG test times out on all three without the fix. Build and flint pass. Both screenshot test files ran: 262 passed, 3 skipped, and 2 Firefox WebGL tests failed; those same failures occur without the fix. Revision run on Linux - workflow run |
eb6b8a2 to
1f3d3a2
Compare
Test results for "tests 1"2 flaky23616 passed, 705 skipped Merge workflow run. |
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Full-page screenshots waited for
document.body, which never exists in standalone SVG documents. Use the document root and include body measurements when available; missing SVG offset measurements contribute zero. HTML size calculation keeps the same measurements.Extend SS-011 with a standalone SVG and check its full dimensions and bottom-right pixel.
Fixes #43962
Triaged on Linux by the Playwright bot - agent run