Repository navigation
fix(mcp): report one-based console source lines - #43975
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
tests failed. |
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
|
Hi, I'm the Playwright bot. I fixed the failing debug-output expectation. The |
23f4cd8 to
1099486
Compare
Test results for "MCP"1 failed 5193 passed, 616 skipped Merge workflow run. |
🟢 The remaining failure is a confirmed pre-existing flakeHi, I'm the Playwright bot. I checked the latest MCP report for DetailsThe latest report has one failure. It is not likely caused by this PR. The earlier seven Pre-existing flake
The exact same test and Chromium/Linux job failed with the same second-call mismatch on November 2, before this PR existed: #43864, SHA The PR changes console source-line formatting and the matching console/debug expectations. It does not change iframe tool registration or collection, which this failure exercises. CI failures checked by the Playwright bot - agent run Triaged by the Playwright bot - agent run |
The MCP console formatter printed Playwright's zero-based
ConsoleMessage.location().lineNumberunchanged, pointing readers one line before the source.Convert the displayed line to one-based output in the shared formatter, preserving the existing
URL:lineformat. Extend the existing console-message test to check inline and external script locations.The regression fails without the fix in Chrome, Chromium, Firefox and WebKit. With the fix, all 168 console and neighboring CLI devtools tests pass across those projects; build and flint pass.
Fixes microsoft/playwright-mcp#1839
Triaged on Linux by the Playwright bot - agent run