Repository navigation
fix(mcp): do not offer a response body for redirect responses - #43977
Closed
nancy (nancy6547) wants to merge 2 commits into
Closed
nancy (nancy6547) wants to merge 2 commits into
nancy (nancy6547) wants to merge 2 commits into
Conversation
Updated the logic to check for response body availability based on HTTP status codes, clarifying that 3xx redirects do not expose a body. Signed-off-by: nancy <singhnancy2004@gmail.com>
Signed-off-by: nancy <singhnancy2004@gmail.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43976
browser_network_requestshowed thepart="response-body"hint for 3xx responses. Playwright never exposes the body of a redirect response (Response body is unavailable for redirect responses), so the follow-up call returned nothing.canHaveResponseBody()now treats every 3xx status as having no body (it already covered 304).Test: added
browser_network_request does not offer a response body for a redirectintests/mcp/network.spec.ts. It fails on main and passes with the fix.npm run ctest-mcp networkpasses (17 tests).