Open
Conversation
The raiseEvent block was referencing block ids control_event_source_id and control_event_value_id which don't exist in common packages. I didn't remove the code completely in case anyone already has this block in their project, but I don't think we need to show it. In live, it's already basically impossible to access because it messes up the toolbox load. One unknown is if this is needed by micro:bit, which does actually have the block ids. If that's the case, correct fix may be to actually bring the missing block into common packages instead.
…ages into thsparks/fix_radio_more
Collaborator
|
This would mess up microbit right? |
Contributor
Author
That was my concern, yes. A more correct fix is probably to bring the missing block into common-packages. |
Contributor
|
We might have a system where we can just override a block for a specific target, although I'm not super sure of how this would work with C++. Just looked at this a bit, it looks like we have something for game, but again, this is all in TS, so it might be trickier when you throw C++ in the mix. This is the file in arcade, but there is also a file defined in common packages named the same: https://github.com/microsoft/pxt-arcade/blob/b7c058d590b055248d59aeae85e81f88610873be/libs/game/gameoverrides.ts#L7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-arcade#4860
There was an error in the block definition which caused parsing to fail, so the toolbox wasn't loading correctly. Specifically, the
control_event_source_idandcontrol_event_value_idblock ids referenced for thesrcandvalueparams do not exist in this repo. (They're specific to micro:bit.)I've removed the references to those parameters and hidden the block. I didn't want to fully delete the code in case some project somewhere was actually using it, but this way no-one else will try to use it.
TO DO: I have not checked if micro:bit is depending upon this block for its (presumably working) radio implementation.