Repository navigation
Fix same-conversation action credential continuation - #1776
Merged
Paul Lizer (paullizer) merged 2 commits intoOct 17, 2026
Merged
Paul Lizer (paullizer) merged 2 commits into
Paul Lizer (paullizer) merged 2 commits into
Conversation
Preserve server-owned construction profiles across credential pauses without weakening execution guards. Add fresh-agent and browser regressions, safe diagnostics, and versioned documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reference the shared Playwright fixture through its imported module to retain pytest discovery without an unused import. Record the passing browser checks and bump the patch version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Paul Lizer (paullizer)
merged commit Oct 17, 2026
6a70fc3
into
paullizer-react-v2-ui
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.261.344to0.261.346: the continuation fix was implemented in0.261.345, and explicit browser-fixture reuse was added during review in0.261.346.paullizer-react-v2-uibase.Linked issue
N/A. The user chose not to create an associated issue.
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Should this become a Latest Feature card?
Screenshot needed for the card?
Release notes were offered but approval was unavailable, so
docs/explanation/release_notes.mdis unchanged. The feature documentation, user guide, and new fix documentation describe the change.Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedTesting / validation
Python commands used the session virtual environment and the repository's application/functional-test import paths. Application storage, model transport, and provider transport were offline; the browser regression drives the real React card and actual Flask credential/message routes. No live user credentials or production mutations were used.
python -m pytest ui_tests\test_v2_action_credentials_backend.py ui_tests\test_playwright_connection_auth.py ui_tests\test_v2_action_credentials.py -q --tb=short- 26 passed after the fixture-only review fix in3ed7615e4. This explicitly reuses the shared fixture through its imported module, preserving module-local discovery and local/Azure browser selection without suppressing CodeQL's unused-import warning.python -m pytest functional_tests\test_action_credentials_chat_reconstruction.py ui_tests\test_v2_action_credentials_backend.py -q --tb=short- 17 passed on the continuation implementation, including genuinely absent Fact Memory settings, fresh agents, streaming, existing conversation history, new/selected/replaced identities, rejected credentials, persistence failure, real Yamcs protobuf results, and same-conversation browser response delivery.python -m pytest ui_tests\test_v2_action_credentials_backend.py ui_tests\test_v2_action_credentials.py -q --tb=short- 23 passed.python -m pytest functional_tests\test_action_credentials_chat_reconstruction.py functional_tests\test_action_credentials_sk_continuation.py functional_tests\test_action_personal_credentials.py functional_tests\test_action_credentials_orchestration_continuation.py functional_tests\test_action_credentials_bootstrap.py functional_tests\test_agent_delegation_runtime.py functional_tests\test_agent_delegation_auth_handoff.py functional_tests\test_logged_core_plugins.py functional_tests\test_global_agent_scope_gate.py -q --tb=short- 154 passed, 1 failed. The failure is the pre-existing synthetic thought-tracker test described below.python scripts\check_cosmos_response_boundaries.py --run-contracts- 1,079 passed and 244 subtests passed, with external networking blocked. Inventory review: 1,066 owners, 409 doubles, zero review gaps.python -m pytest functional_tests\route_tests\test_route_blueprint_policy_inventory.py functional_tests\route_tests\test_route_unauthenticated_policy_contract.py functional_tests\route_tests\test_route_policy_test_coverage.py -q --tb=short- 30 passed.node .\functional_tests\test_v2_action_personal_credentials.mjs- passed authoring, projection, transport, and stream checks.npm --prefix .\application\v2_ui run build -- --logLevel error- passed, including TypeScript compilation.python .\functional_tests\test_docs_app_surface_coverage.py- 7/7 passed; committed application-surface inventory is current.python .\functional_tests\test_docs_site_quality.py- 6/6 passed.git diff --checkandgit diff --cached --check- passed.Known baseline failures, not hidden or relaxed by this change:
python -m pytest functional_tests\test_logged_core_plugins.py -q --tb=shortfails because its synthetic tracker records no thought events. The same failure was reproduced independently with unchanged baseline application source.test_agent_delegation_entrypoints.pywere reproduced identically against unchanged baseline source. Those fixtures omit dependencies referenced by the extracted functions. This PR does not claim that broader suite is green or change unrelated fixtures.Documentation
Updated
PERSONAL_ACTION_CREDENTIALS.mdand the personal-action-credentials user guide. AddedACTION_CREDENTIAL_CHAT_RECONSTRUCTION_FIX.mdwith the root cause, construction contract, scope, validation results, and baseline limitations. Release-note approval remains outstanding as noted above.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No routes or frontend settings responses were added. Existing security decorators are unchanged. Construction metadata is server-owned and excluded from agent serialization; it does not grant access. New diagnostics retain only allowlisted failure codes, static stages, exception types, and hashed correlations, not exception messages or credential/provider payloads.