Repository navigation
fix(Field): pass isDisabled to CodeEditor - #3457
Merged
Merged
Conversation
CodeEditor supports isDisabled since #3369, so the unused @ts-expect-error tripwire in Field.browser.test.tsx failed test:compile (TS2578). Do what it asked: give CodeEditor the full fieldProps, drop the workaround test and cover CodeEditor in disabledFields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
Lisa18289
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
test:compile componentsonnext(TS2578 "Unused '@ts-expect-error' directive" inField.browser.test.tsx).CodeEditor supports
isDisabledsince #3369. It reachednextwith the main→next forward-merge 88b2478, and that fired the tripwire #3379 added for exactly this case. This PR does what the tripwire asks:Field.tsx: drop theignoredIsDisabled/codeEditorFieldPropsworkaround and passCodeEditor: fieldProps.Field.browser.test.tsx: delete "disabled Field does not pass isDisabled to CodeEditor" and the tripwire test, drop theCodeEditorPropsimport, and cover CodeEditor indisabledFields.Only
nextis affected:mainhas noCodeEditor.isDisabled, so its workaround and tripwire are still valid there.The same commit (4f1c7fe) is already on #3324 (
feat/skeleton-mode-content). This PR unblocksnextwithout waiting for that one. Once this merges, the commit drops out of #3324 on its next merge ofnext.Verified locally:
pnpm nx test:compile componentspasses.pnpm nx test:browser components -- --browser.name=webkit src/integrations/react-hook-form/components/Fieldpasses 38/38.🤖 Generated with Claude Code