Repository navigation
docs(List): add performance guidance for items, modals and batches - #3527
Merged
Merged
Conversation
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
A new "Performance" section on the List page, plus a Best Practices bullet: render items as memo components, keep modals and data loading at list level, keep the batch size of 20. USAGE.md points agents to it. Based on the measurements in #3524: a memo item component behind an inline render function cuts a parent re-render of 200 rich items from 181 to 117 ms; a closed Modal per item costs little, its controller and app wrappers multiply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mfal
force-pushed
the
claude/docs-list-performance
branch
from
October 20, 2026 08:14
067c5e3 to
c90c78f
Compare
mfal
marked this pull request as ready for review
October 20, 2026 08:17
Lisa18289
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds performance guidance for
Listusers: a new Performance section on the List page, a Best Practices bullet that points to it, and one line inUSAGE.mdso agents in consumer repos find it without opening the List page first.Targets
next: the guidance builds onrenderDependenciesfrom #3526, which exists only there.What the section says
renderDependencies. An inline render function re-renders every item on every parent render. WithrenderDependenciesonList.Item/List.TableRow, an item re-renders only when its data or a listed value changes;[]when the render function reads nothing but the item. Rules: list every outside value, keep listed values stable (useCallback/useMemo), keep data stable. Details link to the existing "Item-Inhalte und externer State" section instead of repeating it.Modalrenders nothing until opened, but its controller and whatever the app wraps around it multiply per item. Shows one shared modal at list level that receives the selected item, withrenderDependencies={[edit]}and the pitfalls: do not reset the selection on close; withoutrenderDependencies,setSelectedre-renders every item.Basis
Measured with the harness from #3524 (200 rich items, Chromium, production React):
renderDependencies(feat(List): skip item and table row re-renders for inline callbacks and renderDependencies #3526), ~40 %;React.memoon item components, and per-item modals in 59 lists — the case this guidance targets.Notes
memoitem components and targetedmain. With feat(List): skip item and table row re-renders for inline callbacks and renderDependencies #3526 onnext,renderDependenciesis the fast path, so the PR moved tonextand the section now recommends it.USAGE.mdships with the package, so this merge counts as release-relevant.Related: #3528 (measurement results)
🤖 Generated with Claude Code