Repository navigation
perf(components): memoize the slot context value - #3588
Merged
Merged
Conversation
SlotContextProvider built a new context object on every render, so every slotted component re-rendered all slot context consumers below it, even when the slot was unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
mfal
marked this pull request as ready for review
October 27, 2026 13:49
Lisa18289
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlotContextProviderbuilt{ ...parentContext, [component]: slot }on everyrender. Every slotted component therefore handed its slot context consumers a
new value on each render and re-rendered them, e.g. the buttons of a
confirmation modal, although the slot had not changed.
The value is now memoized on
parentContext,componentandslot.The new browser test re-renders a slotted component with a changed unrelated
prop and asserts that a memoized
useSlotContext()consumer below it does notre-render; it fails without the fix. Changing the slot still re-renders the
consumer.
Independent of #3579, which fixes the same pattern in the props context.
🤖 Generated with Claude Code