Repository navigation
fix(Markdown): scroll wide tables instead of overflowing the container - #3614
Merged
Merged
Conversation
A table cannot shrink below its min-content width. Markdown now wraps it in a box that carries the border and corner radius and scrolls horizontally, so the table stays inside narrow containers. Closes #3596 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lisa18289
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
…shot covers it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
Lisa18289
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Co-authored-by: Lisa18289 <84317589+Lisa18289@users.noreply.github.com>
The update-screenshots run re-captured the SkeletonMode calendar scenario with today's month. That scenario is date-dependent and fixed separately in #3616. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lisa18289
marked this pull request as ready for review
November 2, 2026 09:06
Lisa18289
enabled auto-merge (squash)
November 2, 2026 09:06
ins0
reviewed
Nov 2, 2026
ins0
left a comment
ins0
left a comment
Member
There was a problem hiding this comment.
Nit: The PR adds a div around every table in the host output. packages/remote-react-components/CONTRIBUTE.md ("Running them on a pull request") asks for the run-cross-version-tests label on such changes. I don't expect a divergence: Markdown has been a remote element since the remote components were introduced, so old and current remote output both go through the same current host renderer. The label would confirm that before the merge instead of in the scheduled run.
…y scrolls A replaced table renderer has no container, so the border, radius and background stay on the table element, like in Table. The container gets the Flow scrollbar and is named tableContainer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lisa18289
added
update-screenshots
github-actions
Bot
removed
run-cross-version-tests
update-screenshots
Lisa18289
added
update-screenshots
github-actions
Bot
removed
update-screenshots
Co-authored-by: Lisa18289 <84317589+Lisa18289@users.noreply.github.com>
The screenshot cannot tell scrolling from clipping, so a wheel scroll asserts that the container really scrolls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
✅ Cross-Version Tests PassedThe current host still renders old published remote versions correctly (iframe) and in the same DOM shape (in-process). Iframe harness (attribute-accurate): ✅ passed In-process harness (structure-only): ✅ passed |
Lisa18289
added a commit
that referenced
this pull request
Nov 2, 2026
A screenshot cannot tell a scrolling container from a clipping one, so that case still needs a browser test that fails for the wrong one (#3614). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ins0
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GFM table can't shrink below its min-content width, so in a narrow container (e.g. the AIssistant drawer) it stuck out past the Markdown box. Markdown now wraps each table in a box that carries the border, corner radius and background and scrolls horizontally. The table keeps its full width when it fits.
A new "Markdown wide table" visual scenario covers the fix. In Firefox the bottom table corners anti-alias slightly differently now that the wrapper clips them, which changes a few pixels in two existing baselines.
Closes #3596
🤖 Generated with Claude Code