Repository navigation
Conversation
…he wizard The timer the phone starts after a bolus never reached the watch: nothing was sent, and its notifications are ongoing ones, which Wear OS does not bridge. Now the phone sends the timer's start and end with every status, also from a client's copy. The watch draws a dashed line at the end in its BG graph, on the graph screen and the tile, with the minutes left at it. The watch sets its own alarm at that time and rings by itself, so it rings with the phone out of reach too: a vibrating notification with Silence and +5 min, and a screen with the same two buttons over it. Both go to the phone, which stops or moves the timer; a client relays to its master. The next status closes the screen. The watch wizard gets a carb time page behind a new watch setting, off by default, next to the meal type one: minutes until the carbs are eaten, with a "Set alarm" bell that is on by default once the time is positive. The phone starts the timer after the bolus and moves the meal type's eCarbs with the meal, as its own wizard does. The custom watchface graph and the V4 face do not show the timer yet.
…ge fits The ring screen is gone: Android does not start an activity from an alarm in the background, so it only showed up behind the notification's "Open app". The vibrating notification with Silence and +5 min is the ring now. The carb time page says "Carb time [min]" on two lines and keeps the bell row on one line, so the - and + buttons sit still from "Now" to "+60". The face's graph complication writes the minutes left at the timer's line too.
Between the start and the ring the watch only showed the line in the graph, so the timer could not be stopped from the watch before it rang. While it runs, a silent notification now sits in the stream: "Time to eat, Rings at 19:25", with Stop and +5 min. It follows every new end time, goes away when the timer ends, and times out by itself at the ring, when the ring's own notification takes over.
…ed elsewhere Silence from the watch, or Stop from a client or from the notification, ended the timer and muted the sound, but the alarm screen on the phone stayed open with nothing left to offer. It now closes when the timer is gone. The phone's own "Silence alarm" keeps it open, as for every alarm. Also on the watch wizard's request page: the carb time and the percentage share one line when both are there, since a third line under the check fell off the screen. And a note for translators that the carb time label must stay short.
…tion and silences the ring Wear OS lets the user swipe an ongoing notification away. For the running timer that notification is the only Stop and +5 min on the watch, so it comes back at once: its delete intent posts it again while the timer runs. Our own cancel does not fire the delete intent, so Stop, the ring and a timer ended on the phone still clear it. A swipe on the ringing notification silences the timer, as on a clock's alarm. Before, the phone kept ringing with nothing left on the watch to stop it. On the phone, the alarm screen now also closes when the timer is moved +5 min from the watch or a client, not only when it is stopped there. The alarm has rung when that screen opens, so a timer that has not rung is one that was extended.
A watch vibrates once per notification, while the phone rings until it is answered. So the ring is posted again every 30 s until 5 minutes after the end, with the same alarm intent: Silence, +5 min and a swipe on the watch, and a timer stopped or moved on the phone, cancel or replace that alarm and the repeats with it. The window for a valid alarm grows from 2 minutes around the end to 2 minutes before and 7 minutes after, so the repeats pass and an old timer is still ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.