Optimize CPU masked_scatter for contiguous arrays#3670
Draft
AK-Khan02 wants to merge 1 commit into
Draft
Conversation
Author
|
WIP: this currently adds a scoped contiguous CPU fast path for masked_scatter with measurable local speedups. I’m still exploring whether a chunked prefix-count approach or other approaches could safely optimize the larger/general path further, so feedback on the current fast-path shape is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3669.
Adds a CPU fast path for
masked_scatterwhenmask,src, andoutare row-contiguous. The existingContiguousIteratorimplementation remains the fallback for strided and broadcasted cases.Why
The CPU implementation previously used the general iterator path for all cases. For contiguous arrays, direct pointer indexing avoids per-element iterator/stride bookkeeping while preserving the same source-consumption semantics.
Local benchmark
CPU-only local benchmark, float32:
Validation