Skip to content

Fail closed when wallet remote lookup fails - #18

Draft
geroldsteiner67 wants to merge 1 commit into
mainfrom
fix/wallet-create-remote-lookup
Draft

geroldsteiner67 wants to merge 1 commit into
mainfrom
fix/wallet-create-remote-lookup

Conversation

@geroldsteiner67

Copy link
Copy Markdown
Contributor

Summary

  • Fail wallet creation if the remote wallet lookup fails, instead of treating an error as absence and creating a potentially conflicting genesis.
  • Preserve a newly generated owner key across a failed lookup so retry uses the same address.
  • Add a regression test for a failed lookup and retry.

Validation

  • cargo check -p modality-cli-contract --features p2p
  • cargo clippy -p modality-cli-contract --features p2p -- -D warnings -A clippy::too_many_arguments
  • cargo test -p modality-cli-contract --features p2p failed_lookup_does_not_create_wallet_or_replace_generated_key
  • RUSTFLAGS="-D warnings" cargo check --all
  • RUSTFLAGS="-D warnings" cargo check --all --tests --examples
  • cargo clippy --all -- -D warnings -A clippy::too_many_arguments

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant