Skip to content

Reject zero ping attempts and fix testnet ping setup - #30

Open
geroldsteiner67 wants to merge 1 commit into
mainfrom
fix/ping-zero-count-and-join-example
Open

geroldsteiner67 wants to merge 1 commit into
mainfrom
fix/ping-zero-count-and-join-example

Conversation

@geroldsteiner67

Copy link
Copy Markdown
Contributor

Summary

  • Reject modal node ping --times 0 during CLI parsing, avoiding a zero-divisor panic in the average-time summary.
  • Make the testnet join and mining ping examples runnable: create a separate node directory, obtain a complete bootstrapper multiaddr from the bundled network configuration, and quote the copied address.
  • Document that the ping count must be positive.

Validation

  • cargo check -p modality-cli-node
  • cargo clippy -p modality-cli-node -- -D warnings -A clippy::too_many_arguments
  • cargo test -p modality-cli-node ping_count_must_be_positive
  • RUSTFLAGS="-D warnings" cargo check --all
  • RUSTFLAGS="-D warnings" cargo check --all --tests --examples
  • cargo clippy --all -- -D warnings -A clippy::too_many_arguments
  • git diff --check

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant