Repository navigation
Reject zero ping attempts and fix testnet ping setup - #30
Open
geroldsteiner67 wants to merge 1 commit into
Open
geroldsteiner67 wants to merge 1 commit into
geroldsteiner67 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modal node ping --times 0during CLI parsing, avoiding a zero-divisor panic in the average-time summary.Validation
cargo check -p modality-cli-nodecargo clippy -p modality-cli-node -- -D warnings -A clippy::too_many_argumentscargo test -p modality-cli-node ping_count_must_be_positiveRUSTFLAGS="-D warnings" cargo check --allRUSTFLAGS="-D warnings" cargo check --all --tests --examplescargo clippy --all -- -D warnings -A clippy::too_many_argumentsgit diff --check