Repository navigation
docs(building-sites/extras): fact-check pass, en/ru sync - #678
Open
Ibochkarev wants to merge 2 commits into
Open
Ibochkarev wants to merge 2 commits into
Ibochkarev wants to merge 2 commits into
Conversation
… the RU locale Three markers of the editorial pass are resolved against the code: - the actions of a row. **Uninstall** rolls the elements of an installed package back, **Reinstall** runs the installation again over it — both call the same handlers, but they do different things. **Update** shows when the setting `auto_check_pkg_updates` is on and the provider has a newer version; **Check For Updates** shows when the package came from a provider and the setting is off, so MODX does not know of a newer version yet (`Processors/Workspace/Packages/GetList.php`, the method `checkForUpdates()`); - `OnPackageInstall` carries the `package` and the `action`: `install` for the first installation, `upgrade` when a newer version is installed over an older one (`Processors/Workspace/Packages/Install.php`). The setting `abort_install_on_unsatisfied_dependency` is added to the table of the settings. The Russian pages follow the English ones: the same headings, the same tables and the same wording. The link to the section of the dependencies carried the anchor `#зависимости`, which the site cannot resolve — it transliterates the Cyrillic — so it is `#zavisimosti` now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fact-check pass of the section
building-sites/extrasagainst the code of the MODX 3.x branch (a7096dbe1).The section was written for MODX 2: half of the interface it names does not exist any more. 39 discrepancies were found — 7 PHANTOM, 11 STALE, 3 ORPHAN, 15 UNDOCUMENTED, 3 UNVERIFIABLE. All of them are closed.
Fixed
preexisting_mode= 2), or delete the version in the card of the package.disableContextMenuAction: true). The actions are the buttons of the row: Install, Uninstall, Reinstall, Update, Check For Updates, Remove, View Details.simplexml_load_string, the request carriesAccept: application/xml, and the provider is checked on save withGET <service_url>/verify.https://rest.modx.com/extras/, and it ships with MODX 3.x — not with 2.0.0.core/packages/<signature>/and the archive. Uninstall rolls the elements back and leaves the archive, the directory and the record in place.Added
The full reference: the actions of a row and when they show, the card of a package with its uploaded versions, the dependencies and the setting
abort_install_on_unsatisfied_dependency, the upload of an archive, Purge Old Packages, the permissions (workspaces,packages,providers,file_upload), the eventsOnPackageInstall/OnPackageUninstall/OnPackageRemove, the settings and the table of the processors.Screenshots
Five screenshots of the MODX 2 panel are gone from the repository — they showed the grid of the providers, the wizard of the provider, the wizard of the download, the setup options and the uninstall. The frames that replace them are named in
.temp/docs-review/media-todo.md; they need a test stand of MODX 3. The four screenshots of the Package Management page that are of MODX 3 stay, and two of them are now in the text.Defects of the core
Reported in modxcms/revolution:
modTransportManager::getProviders()filters on a columndisabledthat the tabletransport_providersdoes not have (the flag isactive), so the query fails withUnknown column 'disabled'.modTransportManager::scanForUpdates()andscanForPackages()callscanForUpdates()andscanForPackages()on the provider, andmodTransportProviderhas no such methods.default_provideris read by the page of Package Management, but it is not registered as a system setting, so it cannot be set in the manager.Locales
The Russian pages follow the English ones: the same headings, the same tables with the same number of rows, the same wording. The link to the section of the dependencies carried the anchor
#зависимости, which the site cannot resolve — it transliterates the Cyrillic — so it is#zavisimostinow.Checks
markdownlint-cli@0.18(the version used by CI): 0 issuesFACT?,EXAMPLE?orMEDIAare left in the files