git-reader - improve collection changeset performance by caching the sorted refs#1388
Open
alexcottner wants to merge 1 commit into
Open
git-reader - improve collection changeset performance by caching the sorted refs#1388alexcottner wants to merge 1 commit into
alexcottner wants to merge 1 commit into
Conversation
leplatrem
approved these changes
Jun 25, 2026
leplatrem
left a comment
leplatrem
left a comment
Contributor
There was a problem hiding this comment.
Good catch! I have doubt about caching logics though
| return decorator | ||
|
|
||
|
|
||
| @lru_cache(maxsize=500) |
Contributor
There was a problem hiding this comment.
Where does this 500 come from? (number of possible collections + margin? maybe better as a config)
| def filter_refs( | ||
| repo: pygit2.Repository, | ||
| bid: str, | ||
| cid: str, |
Contributor
There was a problem hiding this comment.
Why don't we need any cache_bust here? How does the caching of references catch up the git repo update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RMST-438
When investigating CPU spikes, found that the
raw_listall_referencescall was responsible for 75% of the effort inget_collection_changeset.Caching the results from this gives us a pretty good performance boost in some synthetic testing.
Tests were running jmeter with 100 threads in 100 loops.