Fix OpenCode process cleanup on Obsidian shutdown#68
Open
yangyangyanghub wants to merge 1 commit into
Open
Conversation
Use synchronous shutdown cleanup and terminate Windows process trees so plugin-started opencode serve processes do not remain after Obsidian exits. Co-authored-by: Admin <wuyang0128@foxmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where
opencode servecan remain running after Obsidian exits, especially on Windows.The previous Windows cleanup only killed the parent process and direct child processes. Because the plugin starts OpenCode through a shell, the actual
opencode.exeserver process can remain orphaned and keep listening on the configured port.Changes
taskkill /F /T /PIDon Windows to terminate the full process tree.stopSync.quit.Verification
bun run tsc -noEmit -skipLibCheck --ignoreDeprecations 5.0bun run esbuild.config.mjs productionopencode serveprocess remains.🤖 Generated with Claude Code