Skip to content

Let lock to use redis_options method#262

Open
glasses618 wants to merge 1 commit into
nateware:masterfrom
glasses618:lock_use_redis_options
Open

Let lock to use redis_options method#262
glasses618 wants to merge 1 commit into
nateware:masterfrom
glasses618:lock_use_redis_options

Conversation

@glasses618

Copy link
Copy Markdown

I encountered the same issue as #157 solved, but is for lock method.
I am not sure why #157 didn't let lock to use redis_options, but I think it should be.

This PR introduce redis_options on lock methods and add some test cases.
P.S. I didn't add test case on sorted_set because it didn't have any options yet.

class Roster
include Redis::Objects
counter :available_slots, :start => 10
counter :pitchers, :limit => :max_pitchers
counter :basic
hash_key :contact_information, :marshal_keys=>{'updated_at'=>true}
lock :resort, :timeout => 2
value :starting_pitcher, :marshal => true
list :player_stats, :marshal => true
set :outfielders, :marshal => true
sorted_set :rank

@codecov

codecov Bot commented Sep 18, 2021

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@glasses618 glasses618 changed the title Let lock to use redis_options Let lock to use redis_options method Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant