Skip to content

Officialize OneGate Vault experience#51

Open
Jim8y wants to merge 3 commits into
neoorder:masterfrom
Jim8y:codex/p4-onegate-vault-official
Open

Officialize OneGate Vault experience#51
Jim8y wants to merge 3 commits into
neoorder:masterfrom
Jim8y:codex/p4-onegate-vault-official

Conversation

@Jim8y

@Jim8y Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Scope

  • Adds a narrow OneGate Vault classifier for the existing Vault dApp only.
  • Shows an Official badge for OneGate Vault in the dApp list.
  • Adds an official Vault section to the dApp details page with status, rules, and history guidance.
  • Adds English and Simplified Chinese strings for the new Vault official experience.

Validation

  • git diff --check
  • iOS simulator build: dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:BuildIpa=false -p:EnableCodeSigning=false
  • Android emulator build: dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:AndroidSdkDirectory=/opt/homebrew/share/android-commandlinetools -p:JavaSdkDirectory=/opt/homebrew/Cellar/openjdk@17/17.0.19/libexec/openjdk.jdk/Contents/Home -p:EmbedAssembliesIntoApk=true
  • iOS simulator verified on iPhone 17 Pro / iOS 26.5: created a local test wallet, opened Apps, confirmed the OneGate Vault Official badge and details section.
  • Android emulator verified on Android 16 / emulator-5554: installed the APK, opened Apps, confirmed the OneGate Vault Official badge and details section; crash buffer was empty.

Screenshots

Known limitations

  • This PR does not add a new GAS Claim feature. It only improves the existing OneGate Vault dApp presentation.
  • It does not change the dApp runtime trust bar or wallet signing flow.

@Jim8y

Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

iOS and Android simulator verification screenshots:

iOS Simulator
iOS OneGate Vault official experience

Android Emulator
Android OneGate Vault official experience

@erikzhang

Copy link
Copy Markdown
Contributor

conflicts

…ult-official

# Conflicts:
#	OneGateApp/Pages/DAppsPage.xaml
Copilot AI review requested due to automatic review settings June 21, 2026 15:01
@Jim8y

Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

PR #51 refresh after latest master/review sweep

Scope updated:

  • Merged latest master into codex/p4-onegate-vault-official.
  • Resolved OneGateApp/Pages/DAppsPage.xaml by keeping the current redesigned dApp card/list layout and adding the Official badge only for OneGate Vault.
  • Filled the OneGate Vault resource keys across all locale files; resource key parity is clean.

Validation:

  • rg -n "<<<<<<<|=======|>>>>>>>" OneGateApp -> no matches.
  • git diff --check -> clean.
  • Resource parity -> OK: 15 resource files match 292 keys.
  • iOS build passed: DEVELOPER_DIR=/Applications/Xcode-26.5.0.app/Contents/Developer dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:BuildInParallel=false.
  • Android build passed: JAVA_HOME=/opt/homebrew/Cellar/openjdk@17/17.0.19/libexec/openjdk.jdk/Contents/Home dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:BuildInParallel=false -p:EmbedAssembliesIntoApk=true.
  • iOS simulator UI verified on OneGate-PR51-iPhone17 / iOS 26.5: launched, created a test wallet, opened Apps, and verified the OneGate Vault detail page. Local note: this Xcode 26.5 simulator rejected the first install with dyld CODESIGNING 2 Invalid Page; re-signing the loose simulator .dylib files plus the app bundle fixed launch, so I treated it as a local simulator signing/deploy artifact rather than app source behavior.
  • Android emulator UI verified on emulator-5554: Apps list badge, Vault detail page, and crash buffer checked (adb logcat -b crash -d was empty).

Screenshots (stable release assets; not committed to the repo):

iOS Vault Details

Android Vault Details

Android Apps Vault Badge

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR “officializes” the OneGate Vault dApp experience by adding an “Official” badge in the dApp list and an official information panel on the dApp details page, backed by new localized strings.

Changes:

  • Add OneGate Vault classification logic (IsOneGateVault) and a derived status text for display.
  • Display an “Official” badge in the dApp list and add an “Official OneGate Vault” section in the details view.
  • Add new localization keys (EN + multiple locales) for the official Vault experience.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
OneGateApp/Properties/Strings.resx Adds EN strings for Official/Vault official panel content.
OneGateApp/Properties/Strings.Designer.cs Adds strongly-typed accessors for new localization keys.
OneGateApp/Properties/Strings.de.resx Adds DE strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.es.resx Adds ES strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.fr.resx Adds FR strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.id.resx Adds ID strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.it.resx Adds IT strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.ja.resx Adds JA strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.ko.resx Adds KO strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.nl.resx Adds NL strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.pt-BR.resx Adds PT-BR strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.ru.resx Adds RU strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.tr.resx Adds TR strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.vi.resx Adds VI strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.zh-Hans.resx Adds Simplified Chinese strings for the new Official/Vault official panel content.
OneGateApp/Properties/Strings.zh-Hant.resx Adds Traditional Chinese strings for the new Official/Vault official panel content.
OneGateApp/Pages/DAppsPage.xaml Renders an “Official” badge next to Vault in the dApp list.
OneGateApp/Pages/DAppDetailsPage.xaml Adds an official Vault information panel (status/rules/history).
OneGateApp/Data/DApp.cs Adds Vault classifier + Vault status text for UI binding.
Files not reviewed (1)
  • OneGateApp/Properties/Strings.Designer.cs: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread OneGateApp/Data/DApp.cs Outdated
Comment thread OneGateApp/Pages/DAppDetailsPage.xaml Outdated
@Jim8y

Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Follow-up fix for the remaining review threads in PR #51.

Handled in c4a6c05:

  • Hardened DApp.IsOneGateVault so the fallback URL check parses the URL and matches https://neomini.app/miniapps/miniapp-gas-lucky-pool by host + path instead of substring matching. This prevents URLs like https://evil.example/?u=neomini.app/... from being marked official.
  • Changed the Vault detail status label to keep Success only for active Vaults and switch to Danger when IsActive == false, so unavailable status is not rendered green.

Re-validated after this commit:

  • git diff --check -> clean.
  • rg -n "<<<<<<<|=======|>>>>>>>" OneGateApp -> no matches.
  • iOS simulator build passed with -p:RuntimeIdentifier=iossimulator-arm64 -p:CodesignKey=-. App bundle and loose .dylib signatures verified with codesign --verify --strict; installed and launched on OneGate-PR51-iPhone17 / iOS 26.5; Vault detail UI verified.
  • Android build passed with explicit AndroidSdkDirectory; installed on emulator-5554; Vault detail UI and Apps-list official badge verified; adb logcat -b crash -d was empty.

Updated screenshots (same stable release assets, overwritten with the latest simulator captures; not committed to the repo):

iOS Vault Details

Android Vault Details

Android Apps Vault Badge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants