Skip to content

Improve dApp detail page#55

Open
Jim8y wants to merge 3 commits into
neoorder:masterfrom
Jim8y:codex/p8-dapp-detail-page
Open

Improve dApp detail page#55
Jim8y wants to merge 3 commits into
neoorder:masterfrom
Jim8y:codex/p8-dapp-detail-page

Conversation

@Jim8y

@Jim8y Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Scope

  • Improve the existing dApp detail page only.
  • Add clear source information, OneGate catalog status, website host, runtime permission explanation, recent-open state, and localized tags.
  • Keep the existing open, favorite, add-to-home, share, screenshots, description, and language flows intact.

Validation

  • git diff --check
  • iOS simulator: built, installed, opened N3 Governance details from Apps, verified source/permissions/recent activity/tags rendering, and verified Open still launches the dApp WebView.
  • Android emulator: built, installed, opened N3 Governance details from Apps, verified source/permissions/recent activity/tags rendering, verified Open launches the dApp WebView, and checked crash buffer was empty.

Screenshots

Known limitations

  • Recent activity uses the existing local dapps/recent list, so it only indicates whether the app was recently opened on this device.
  • Permission details are a runtime explanation; this PR does not add a new permission registry or change dApp execution behavior.

Copilot AI review requested due to automatic review settings June 21, 2026 06:44
@Jim8y

Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

iOS and Android simulator verification screenshots:

Verification:

  • git diff --check
  • Localized resource parity check across all Strings*.resx files: 292 keys each
  • iOS simulator build: net10.0-ios, iossimulator-arm64
  • Android emulator build: net10.0-android, android-arm64
  • iOS Simulator: verified DApp Details renders the metadata cards and that game type is included in Tags (GameFi, 桌游)
  • Android emulator: verified DApp Details renders the metadata cards and that game type is included in Tags (GameFi, Board); no OneGate crash entries in crash buffer

Review follow-up:

  • Included GameTypeDisplayName in the existing Tags metadata card.
  • Removed the standalone Game Type rows from the detail page so the field is not left outside the new metadata layout.
  • Added the new DApp detail resource keys to every supported locale.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the existing dApp detail page UI by adding clearer provenance and contextual metadata (source info, catalog/external status, website host, runtime permission explanation, recent-open state, and localized tags) while preserving existing actions/flows (open, favorite, add-to-home, share, screenshots, description, languages).

Changes:

  • Added new localized string resources for dApp source/status, permissions summary, recent activity, and tags (EN + zh-Hans).
  • Extended DAppDetailsPage code-behind with computed display properties (hosts/status/tags/recent state) derived from the bound DApp and local settings.
  • Refactored DAppDetailsPage XAML layout to present the new metadata in “Card” sections while keeping existing content sections.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
OneGateApp/Properties/Strings.zh-Hans.resx Adds zh-Hans translations for new dApp detail metadata labels and helper text.
OneGateApp/Properties/Strings.resx Adds English strings for new dApp detail metadata labels and helper text.
OneGateApp/Properties/Strings.Designer.cs Regenerates strongly-typed resource accessors for the new string keys.
OneGateApp/Pages/DAppDetailsPage.xaml.cs Computes source/website hosts, catalog vs external status, recent-open text, and localized tag display for binding.
OneGateApp/Pages/DAppDetailsPage.xaml Updates the dApp details UI to render the new source/permissions/recent activity/tags sections in Card layouts.
Files not reviewed (1)
  • OneGateApp/Properties/Strings.Designer.cs: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread OneGateApp/Pages/DAppDetailsPage.xaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants