Improve dApp detail page#55
Open
Jim8y wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
iOS and Android simulator verification screenshots:
Verification:
Review follow-up:
|
There was a problem hiding this comment.
Pull request overview
Improves the existing dApp detail page UI by adding clearer provenance and contextual metadata (source info, catalog/external status, website host, runtime permission explanation, recent-open state, and localized tags) while preserving existing actions/flows (open, favorite, add-to-home, share, screenshots, description, languages).
Changes:
- Added new localized string resources for dApp source/status, permissions summary, recent activity, and tags (EN + zh-Hans).
- Extended
DAppDetailsPagecode-behind with computed display properties (hosts/status/tags/recent state) derived from the boundDAppand local settings. - Refactored
DAppDetailsPageXAML layout to present the new metadata in “Card” sections while keeping existing content sections.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| OneGateApp/Properties/Strings.zh-Hans.resx | Adds zh-Hans translations for new dApp detail metadata labels and helper text. |
| OneGateApp/Properties/Strings.resx | Adds English strings for new dApp detail metadata labels and helper text. |
| OneGateApp/Properties/Strings.Designer.cs | Regenerates strongly-typed resource accessors for the new string keys. |
| OneGateApp/Pages/DAppDetailsPage.xaml.cs | Computes source/website hosts, catalog vs external status, recent-open text, and localized tag display for binding. |
| OneGateApp/Pages/DAppDetailsPage.xaml | Updates the dApp details UI to render the new source/permissions/recent activity/tags sections in Card layouts. |
Files not reviewed (1)
- OneGateApp/Properties/Strings.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erikzhang
reviewed
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Validation
git diff --checkScreenshots
Known limitations
dapps/recentlist, so it only indicates whether the app was recently opened on this device.