Skip to content

Improve gaming hub experience#56

Open
Jim8y wants to merge 4 commits into
neoorder:masterfrom
Jim8y:codex/p9-gaming-hub-polish
Open

Improve gaming hub experience#56
Jim8y wants to merge 4 commits into
neoorder:masterfrom
Jim8y:codex/p9-gaming-hub-polish

Conversation

@Jim8y

@Jim8y Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Scope

  • Add a focused Gaming Hub status card with wallet connection state and game catalog readiness.
  • Add a Recently played row for gaming dApps using the existing local dapps/recent history.
  • Improve the Gaming empty/loading presentation without changing game execution or dApp runtime behavior.
  • Refresh Gaming Hub recents when a gaming dApp is opened.

Validation

  • iOS Simulator: dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:BuildIpa=false -p:EnableCodeSigning=false
  • iOS Simulator: installed and launched on iPhone 17 Pro / iOS 26.5, opened Gaming, opened Pixudi, returned to verify Recently played.
  • Android Emulator: dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:AndroidSdkDirectory=/opt/homebrew/share/android-commandlinetools -p:JavaSdkDirectory=/opt/homebrew/Cellar/openjdk@17/17.0.19/libexec/openjdk.jdk/Contents/Home -p:EmbedAssembliesIntoApk=true
  • Android Emulator: installed and launched on emulator-5554, opened Gaming, verified wallet/game status and Recently played.
  • Android crash buffer: empty after validation.

Screenshots

Known limitations

  • This PR does not change the WebView/game runtime. Individual game content still depends on the upstream dApp loading successfully. During iOS validation, Pixudi opened and updated Hub recents, but its remote page content did not finish rendering before returning to Gaming.

Copilot AI review requested due to automatic review settings June 21, 2026 07:00
@Jim8y

Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

iOS and Android simulator verification screenshots:

Verification:

  • git diff --check
  • Localized resource parity check across all Strings*.resx files: 285 keys each
  • iOS simulator build: net10.0-ios, iossimulator-arm64
  • Android emulator build: net10.0-android, android-arm64
  • iOS Simulator: launched and verified the Gaming tab after the review fix
  • Android emulator: launched and verified the Gaming tab; crash buffer was empty

Review follow-up:

  • Removed the wallet/catalog status card that duplicated low-value information.
  • Reworked the recently played game cards with fixed height and centered icon layout.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Gaming hub UI by adding a status card (wallet connection + catalog readiness), introducing a “Recently played” row powered by the existing dapps/recent history, improving the empty/loading presentation, and refreshing hub state after launching a gaming dApp.

Changes:

  • Add new localized strings for Gaming hub status/empty/recents.
  • Update GamingPage to load recent IDs from settings, compute status text, and expose a recent-games collection for XAML binding.
  • Invalidate GamingPage recents after opening a gaming dApp so the hub refreshes on return.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
OneGateApp/Properties/Strings.zh-Hans.resx Adds Simplified Chinese strings for the new Gaming hub UI elements.
OneGateApp/Properties/Strings.resx Adds new English strings for the new Gaming hub UI elements.
OneGateApp/Properties/Strings.Designer.cs Regenerates strongly-typed accessors for the new localized strings.
OneGateApp/Pages/LaunchDAppPage.xaml.cs Invalidates GamingPage after launching a gaming dApp to refresh recents on return.
OneGateApp/Pages/GamingPage.xaml.cs Loads recent IDs from settings, exposes recent-games list + wallet/catalog status text for bindings.
OneGateApp/Pages/GamingPage.xaml Adds the status card + “Recently played” horizontal row, and improves empty/loading UI.
Files not reviewed (1)
  • OneGateApp/Properties/Strings.Designer.cs: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread OneGateApp/Properties/Strings.resx Outdated
Comment thread OneGateApp/Pages/GamingPage.xaml.cs Outdated
Comment thread OneGateApp/Pages/GamingPage.xaml Outdated
Comment thread OneGateApp/Pages/GamingPage.xaml Outdated
@Jim8y

Jim8y commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Conflict refresh after latest master update.

  • Merged origin/master into codex/p9-gaming-hub-polish and resolved GamingPage.xaml.cs by combining both sides: the Gaming Hub recent-games section remains, while the new base restricted-content filter is applied before refreshing the recent-games list.
  • GitHub mergeability is back to MERGEABLE; unresolved review threads remain 0.
  • Android validation passed: dotnet build -f net10.0-android -c Debug -p:EmbedAssembliesIntoApk=true, then installed on emulator-5554, launched org.neoorder.onegate/crc64e93af8ff8666345c.MainActivity, confirmed process stayed running, and captured screenshot.
  • iOS validation passed: dotnet build -f net10.0-ios -c Debug -p:RuntimeIdentifier=iossimulator-arm64 with ad-hoc simulator signing, then installed/launched on iPhone 17 Pro iOS 26.5 simulator and captured screenshot.
  • Existing warnings only: SQLitePCLRaw NU1903 package advisory, plus pre-existing iOS MT7158 duplicate asset metadata warnings on this branch.

Android screenshot:
Android PR 56

iOS screenshot:
iOS PR 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants