Improve accessibility semantics for wallet flows#66
Open
Jim8y wants to merge 2 commits into
Open
Conversation
Contributor
Author
Simulator screenshotsiOS Simulator
Android Emulator
Screenshots are hosted as temporary PR evidence release assets and are not committed to this repository. |
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility semantics across core wallet flows by adding screen-reader friendly descriptions/hints, hiding decorative elements from the accessibility tree, and introducing new localized accessibility-only action labels.
Changes:
- Added new localized string resources for
ToggleFlashlightandCopyAddressacross all locale.resxfiles and updatedStrings.Designer.cs. - Updated wallet-related XAML pages (Send/SendNFT/Scan/Receive/Contacts/NewContact) to provide semantic descriptions and reduce noisy accessibility output (decorative icons/images).
- Updated shared UI components (
SpinnerButton,SettingsView) to expose clearer semantic labels and hide non-informative activity indicators/icons from the accessibility tree.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| OneGateApp/Properties/Strings.resx | Adds ToggleFlashlight and CopyAddress strings (base locale). |
| OneGateApp/Properties/Strings.de.resx | Adds ToggleFlashlight and CopyAddress strings (de). |
| OneGateApp/Properties/Strings.es.resx | Adds ToggleFlashlight and CopyAddress strings (es). |
| OneGateApp/Properties/Strings.fr.resx | Adds ToggleFlashlight and CopyAddress strings (fr). |
| OneGateApp/Properties/Strings.id.resx | Adds ToggleFlashlight and CopyAddress strings (id). |
| OneGateApp/Properties/Strings.it.resx | Adds ToggleFlashlight and CopyAddress strings (it). |
| OneGateApp/Properties/Strings.ja.resx | Adds ToggleFlashlight and CopyAddress strings (ja). |
| OneGateApp/Properties/Strings.ko.resx | Adds ToggleFlashlight and CopyAddress strings (ko). |
| OneGateApp/Properties/Strings.nl.resx | Adds ToggleFlashlight and CopyAddress strings (nl). |
| OneGateApp/Properties/Strings.pt-BR.resx | Adds ToggleFlashlight and CopyAddress strings (pt-BR). |
| OneGateApp/Properties/Strings.ru.resx | Adds ToggleFlashlight and CopyAddress strings (ru). |
| OneGateApp/Properties/Strings.tr.resx | Adds ToggleFlashlight and CopyAddress strings (tr). |
| OneGateApp/Properties/Strings.vi.resx | Adds ToggleFlashlight and CopyAddress strings (vi). |
| OneGateApp/Properties/Strings.zh-Hans.resx | Adds ToggleFlashlight and CopyAddress strings (zh-Hans). |
| OneGateApp/Properties/Strings.zh-Hant.resx | Adds ToggleFlashlight and CopyAddress strings (zh-Hant). |
| OneGateApp/Properties/Strings.Designer.cs | Adds strongly-typed accessors for ToggleFlashlight and CopyAddress. |
| OneGateApp/Pages/SendPage.xaml | Adds semantic descriptions/hints and hides decorative icons/images from accessibility. |
| OneGateApp/Pages/SendNFTPage.xaml | Hides decorative NFT icon and adds semantic labels for address/scan/contact controls. |
| OneGateApp/Pages/ScanPage.xaml | Adds semantic descriptions for camera view and scan/flashlight buttons. |
| OneGateApp/Pages/ReceivePage.xaml | Adds semantic description for QR code container and copy-address button label. |
| OneGateApp/Pages/NewContactPage.xaml | Adds semantic labels for address/label entries and scan button. |
| OneGateApp/Pages/ContactsPage.xaml | Improves toolbar item accessibility text, hides decorative empty-state image, and adds semantic labels for contact items/copy button. |
| OneGateApp/Controls/Views/SpinnerButton.xaml | Adds semantic label to button and hides activity indicator from accessibility. |
| OneGateApp/Controls/Views/SettingsView.xaml | Makes settings rows accessible with description/hint and hides decorative chevron/value labels from accessibility. |
Files not reviewed (1)
- OneGateApp/Properties/Strings.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Latest review follow-up: addressed the two duplicate accessibility announcement comments in 406aeba. Changes:
Validation:
Screenshots: Screenshots are GitHub release assets only and are not committed to the repository. Ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Validation
Known Observation
Screenshots
A screenshot comment with iOS and Android simulator captures is attached below. Screenshots are hosted as release assets and are not committed to the repository.