Repository navigation
github-release: compare with the newest version tag before marking a release Latest - #806
Merged
Merged
Conversation
… older tag Latest Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCpeuxhYEgymbSMcsBXyZd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #805, from its adversarial review. To decide whether to pass
--latest=false,github-release.ymlreads the current "Latest" release, and treated any failure of that lookup (a network error, a 5xx, a rate limit) as "no releases yet". In that case GitHub's default applies (make_latesttrue), so a backfilled older tag or a maintenance release could be marked Latest during an outage. That's reversible, but wrong.Change
It now compares the tag with the newest
vX.Y.Ztag in the repository (gh api --paginate repos/…/git/matching-refs/tags/v, thensort -V). If the lookup fails, the step stops before creating anything (pipefail). It no longer depends on which releases have pages.Verification
I ran the step's script against a stub
gh:--latest=false--latest=false, a version sort, not a text sort-rc1and junk tags presentThe real run that created https://github.com/nesquena/rabl/releases/tag/v0.18.0 used the previous version. It marked v0.18.0 Latest, correctly, because it is the newest tag.
Generated by Claude Code