Repository navigation
fix(api): fall back to MIME icon when preview generation fails - #3037
Open
joshtrichards wants to merge 1 commit into
Open
joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Request MIME icon fallback for activity preview URLs. If a preview provider is available but cannot generate a thumbnail for a file, the preview endpoint can redirect to the file's MIME-type icon instead of returning a broken image. Fixes #760 Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
nickvergessen
removed their request for review
October 20, 2026 17:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request MIME icon fallback for activity preview URLs. If a preview provider is available but cannot generate a thumbnail for a file, the preview endpoint can redirect to the file's MIME-type icon instead of returning a broken image.
Fixes #760
Looked into this when I noticed the default
Resume.odtfile doesn't include an embedded thumbnail so on a new install the icon ends up broken in the Activity stream (but not in Files itself; it already uses the fallback icon). (And, yeah, theResume.odtskeleton file should get fixed too, but that doesn't change the need for this fix here). (P.S. I have no idea where the default skeleton files are maintained; they must be some part of the package build process -- if you know who to ping about about that matter let me know).🤖 AI (if applicable)