[oleksandr-nc]

DockerActions::initGuzzleClient() took the value of the harp-shared-key header from the basic auth credentials, which are only set when the daemon has a key. For a HaRP daemon without one, every call logged two PHP warnings, Undefined array key "auth" and Trying to access array offset on null. The easiest way to get there is Check connection in the register dialog before a key is typed, which is the default state of the form now that the templates no longer prefill a key.

The header now falls back to an empty string. Guzzle already sent an empty header for the missing value, so the requests stay the same and only the warnings are gone. A unit test covers a HaRP daemon without a key.

[oleksandr-nc]

/backport to stable35

[oleksandr-nc]

/backport to stable34

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: ea54cd0b-4b4c-4200-bf32-4ba29172dc1f

📥 Commits

Reviewing files that changed from the base of the PR and between cad3966 and 8444912.

📒 Files selected for processing: 2

• lib/DeployActions/DockerActions.php
• tests/php/DeployActions/DockerActionsTest.php

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

HaRP client initialization now uses an empty string for harp-shared-key when no authentication password is configured. A new test checks that the initialized Guzzle client has null authentication and an empty shared-key header.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 84449

The change safely handles HaRP daemons without credentials, with targeted test coverage.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: preventing PHP warnings for HaRP daemons without a key.
Description check		The description directly explains the warning, the code change, the unchanged request behavior, and the added test.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 PHPStan (2.2.16)

PHPStan reported 1 non-file analysis error(s); analysis is incomplete

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}