fix(tools): require timezone on time tools, inject user timezone into the prompt

ex_app/lib/agent.py

@@ -5,7 +5,7 @@
 import random
 import string
 from collections.abc import Awaitable, Callable
-from datetime import date
+from datetime import date, datetime
 from time import monotonic
 from typing import Any, cast
 
@@ -14,6 +14,9 @@
 from nc_py_api import AsyncNextcloudApp
 from nc_py_api.ex_app import persistent_storage
 
+import pytz
+
+from ex_app.lib.all_tools.lib.tz import user_timezone_async
 from ex_app.lib.all_tools.nextcloud_links import get_absolute_base_url
 from ex_app.lib.all_tools.skills import list_skills_metadata
 from ex_app.lib.graph import CONFIRM_TOOLS_NODE, AgentState, get_graph
@@ -115,6 +118,13 @@ async def react(
 	tools = await get_tools(nc)
 	impulse_threshold = await get_impulse_threshold(nc)
 	destructive_threshold = await get_destructive_threshold(nc)
+	tz_name = user_tz = None
+	try:
+		tz_name = await user_timezone_async(nc)
+		if tz_name:
+			user_tz = pytz.timezone(tz_name)
+	except Exception:
+		tz_name = user_tz = None
 
 	bound_model = model.bind_tools(
 		tools,
@@ -130,12 +140,19 @@ async def call_model(
 			state: AgentState,
 			config: RunnableConfig,
 	):
-		current_date = date.today().strftime("%Y-%m-%d")
+		if user_tz is not None:
+			current_date = datetime.now(user_tz).strftime("%Y-%m-%d")
+			date_suffix = (
+				f" The user's timezone is {tz_name}; use it for the timezone parameter of calendar and task tools."
+			)
+		else:
+			current_date = date.today().strftime("%Y-%m-%d")
+			date_suffix = ""
 
 		system_prompt_text = """
 You are a helpful AI assistant with access to tools, please respond to the user's query to the best of your ability, using the provided tools if necessary. If no tool is needed to provide a correct answer, do not use one. If you used a tool, you still need to convey its output to the user.
 Use the same language for your answers as the user used in their message.
-Today is {CURRENT_DATE}.
+Today is {CURRENT_DATE}.{DATE_SUFFIX}
 Intuit the language the user is using (there is no tool for this, you will need to guess). Reply in the language intuited. Do not output the language you intuited.
 Only use tools if you cannot answer the user without them.
 If you get a link as a tool output, always add the link to your response.
@@ -152,8 +169,10 @@ async def call_model(
 			system_prompt_text += "Use the find_person_in_contacts tool to find a person's email address and location.\n"
 		if tool_enabled("find_person_in_users"):
 			system_prompt_text += "Use the find_person_in_users tool to find a person's userId and user details.\n"
-		if tool_enabled("find_details_of_current_user"):
+		if tz_name is None and tool_enabled("find_details_of_current_user"):
 			system_prompt_text += "Use the find_details_of_current_user tool to find the current user's location and timezone.\n"
+		if tool_enabled("get_current_datetime"):
+			system_prompt_text += "Use the get_current_datetime tool when the user asks for the current date or time.\n"
 		if tool_enabled("list_mails"):
 			system_prompt_text += "Always check for the mail account id before requesting a folder list.\n"
 		if tool_enabled("web_fetch"):
@@ -189,7 +208,7 @@ async def call_model(
 
 		# this is similar to customizing the create_react_agent with state_modifier, but is a lot more flexible
 		system_prompt = SystemMessage(
-			system_prompt_text.replace("{CURRENT_DATE}", current_date)
+			system_prompt_text.replace("{CURRENT_DATE}", current_date).replace("{DATE_SUFFIX}", date_suffix)
 		)
 
 		response = await bound_model.ainvoke([system_prompt] + state["messages"], config)

ex_app/lib/all_tools/assignments.py

@@ -7,6 +7,7 @@
 from nc_py_api import AsyncNextcloudApp
 
 from ex_app.lib.all_tools.lib.impulse import ImpulseRadius, always_confirm, destructive, impulse
+from ex_app.lib.all_tools.lib.tz import get_timezone, starts_at_timestamp, user_timezone_async
 
 
 async def get_tools(nc: AsyncNextcloudApp):
@@ -24,17 +25,18 @@ async def create_scheduled_task(title: str, prompt: str, recurrence_rule: str, t
 		:param title: A title for the Scheduled Task, e.g. "Transcribe audio files" -- This is only for the user's reference and has no effect on the execution of the Scheduled Task.
 		:param prompt: The instructions for the agent carrying out the Scheduled Task (Do not tell it to create a scheduled task here, as this is the instruction that runs as the scheduled task already. So instead of "Create a scheduled task to do X", just pass "Do X" here)
 		:param recurrence_rule: An RRule compliant with RFC 5545 that defines the recurrence rule for the Scheduled Task. For example "FREQ=DAILY;INTERVAL=1" to run the Scheduled Task every day, an empty string as the recurrence_rule means the task does not repeat.
-		:param starts_at: A date time string in ISO 8601 format that defines when the Scheduled Task should start. For example "2025-01-01T09:00:00Z". If not provided, the Scheduled Task will start immediately. Make sure to use the user's timezone for this, obtainable with find_details_of_current_user
-		:param timezone: Timezone (e.g., 'America/New_York') defaults to the user's current time zone
+		:param starts_at: A date time string in ISO 8601 format that defines when the Scheduled Task should start. For example "2025-01-01T09:00:00Z". If not provided, the Scheduled Task will start immediately.
+		:param timezone: Timezone (e.g., 'America/New_York'). Defaults to the user's profile timezone; used to interpret starts_at. Must be a valid IANA timezone name when supplied.
 		:return:
 		"""
 
+		tz = get_timezone(timezone or await user_timezone_async(nc))
 		await nc.ocs('POST', f'/ocs/v2.php/apps/assistant/assignments', json={
 			'title': title,
 			'prompt': prompt,
 			'recurrence': recurrence_rule,
-			'startsAt': int(datetime.datetime.fromisoformat(starts_at.replace('Z', '+00:00')).timestamp()) if starts_at is not None else datetime.datetime.now(datetime.UTC).timestamp(),
-			'timezone': pytz.timezone(timezone).zone if timezone is not None else None
+			'startsAt': starts_at_timestamp(starts_at, tz) if starts_at is not None else datetime.datetime.now(datetime.UTC).timestamp(),
+			'timezone': tz
 		})
 
 		return True
@@ -58,16 +60,17 @@ async def update_scheduled_task(id: int, prompt: None|str = None, recurrence_rul
 		:param id: The ID of the Scheduled Task to update, you can obtain this from the list_scheduled_tasks tool
 		:param prompt: The instructions for the AI carrying out the Scheduled Task. Pass `None` to leave this unchanged. (Do not tell the other AI to create a scheduled task here, as this is the instruction that runs as the scheduled task already. So instead of "Create a scheduled task to do X", just pass "Do X" here)
 		:param recurrence_rule: An RRule compliant with RFC 5545 that defines the recurrence rule for the Scheduled Task. For example "FREQ=DAILY;INTERVAL=1" to run the Scheduled Task every day. An empty string means, it does not repeat. Pass `None` to leave this unchanged.
-		:param timezone A timezone for the scheduled task, set to None to leave this as is.
+		:param timezone: Timezone (e.g., 'America/New_York'). Defaults to the user's profile timezone; used to interpret starts_at. Must be a valid IANA timezone name when supplied.
 		:param starts_at: A date time string in ISO 8601 format that defines when the Scheduled Task should start. For example "2025-01-01T09:00:00Z". If not provided, the Scheduled Task will start immediately. Pass `None` to leave this unchanged.
 		:return:
 		"""
 
+		tz = get_timezone(timezone or await user_timezone_async(nc))
 		return await nc.ocs('PATCH', f'/ocs/v2.php/apps/assistant/assignments/{id}', json={
 			'prompt': prompt,
 			'recurrence': recurrence_rule,
-			'startsAt': int(datetime.datetime.fromisoformat(starts_at.replace('Z', '+00:00')).timestamp()) if starts_at is not None else None,
-			'timezone': pytz.timezone(timezone).zone if timezone is not None else None
+			'startsAt': starts_at_timestamp(starts_at, tz) if starts_at is not None else None,
+			'timezone': tz
 		})
 
 	@tool

ex_app/lib/all_tools/calendar.py

@@ -2,19 +2,22 @@
 # SPDX-License-Identifier: AGPL-3.0-or-later
 import asyncio
 import time
+import uuid
 from datetime import datetime, timezone, timedelta
 from typing import Optional
 
 from niquests import ConnectionError, Timeout
 import pytz
-from ics import Calendar, Event, Attendee, Organizer, Todo
+from icalendar import Event as ICalendarEvent, vCalAddress, vText
+from ics import Calendar, Todo
 from langchain_core.tools import tool
 from nc_py_api import AsyncNextcloudApp, NextcloudApp
 import xml.etree.ElementTree as ET
 import vobject
 
 from ex_app.lib.all_tools.lib.audience import principal_radius
 from ex_app.lib.all_tools.lib.impulse import ImpulseRadius, destructive, impulse
+from ex_app.lib.all_tools.lib.tz import get_timezone, user_timezone
 from ex_app.lib.all_tools.lib.freebusy_finder import find_available_slots, round_to_nearest_half_hour
 
 
@@ -78,41 +81,48 @@ async def list_calendars():
 		"""
 		return await asyncio.to_thread(list_calendars_sync)
 
-	def schedule_event_sync(calendar_name: str, title: str, description: str, start_date: str, end_date: str, attendees: Optional[list[str]], start_time: Optional[str], end_time: Optional[str], location: Optional[str], timezone: Optional[str]):
+	def schedule_event_sync(calendar_name: str, title: str, description: str, start_date: str, end_date: str, attendees: Optional[list[str]] = None, start_time: Optional[str] = None, end_time: Optional[str] = None, location: Optional[str] = None, timezone: Optional[str] = None):
 		# Parse date and times
 		start_date = datetime.strptime(start_date, "%Y-%m-%d")
 		end_date = datetime.strptime(end_date, "%Y-%m-%d")
 
+		# Set timezone (defaults to the user's profile timezone); validated even for
+		# all-day events so a bad value errors instead of being silently ignored
+		timezone = timezone or user_timezone(ncSync)
+		tz = pytz.timezone(get_timezone(timezone))
+
 		# Combine date and time
 		if start_time and end_time:
 			start_time = datetime.strptime(start_time, "%I:%M %p").time()
 			end_time = datetime.strptime(end_time, "%I:%M %p").time()
 
-			start_datetime = datetime.combine(start_date, start_time)
-			end_datetime = datetime.combine(end_date, end_time)
+			# icalendar keeps the timezone as a TZID on datetime values
+			start_datetime = tz.localize(datetime.combine(start_date, start_time))
+			end_datetime = tz.localize(datetime.combine(end_date, end_time))
 		else:
-			start_datetime = start_date
-			end_datetime = end_date
-
-		# Set timezone
-		if timezone != None:
-			tz = pytz.timezone(timezone)
-			start_datetime = tz.localize(start_datetime)
-			end_datetime = tz.localize(end_datetime)
+			# All-day events are DATE values; DTEND is exclusive, so the day after
+			start_datetime = start_date.date()
+			end_datetime = (end_date + timedelta(days=1)).date()
 
 		description_with_ai_note = f"{description}\n\n---\n\nThis event was scheduled by Nextcloud AI Assistant."
 
-		# Create event
-		c = Calendar()
-		e = Event()
-		e.name = title
-		e.begin = start_datetime
-		e.end = end_datetime
-		e.description = description_with_ai_note
-		e.location = location
-		if attendees is not None:
-			for attendee in attendees:
-				e.add_attendee(Attendee(common_name=attendee, email=attendee, partstat='NEEDS-ACTION', role='REQ-PARTICIPANT', cutype='INDIVIDUAL'))
+		# Create event (icalendar keeps the event's timezone as a TZID; the ics library would serialize it to UTC)
+		e = ICalendarEvent()
+		e.add('summary', title)
+		e.add('dtstart', start_datetime)
+		e.add('dtend', end_datetime)
+		e.add('description', description_with_ai_note)
+		if location:
+			e.add('location', location)
+		e.add('uid', str(uuid.uuid4()) + '@context-agent')
+		e.add('dtstamp', datetime.now(pytz.UTC))
+		for attendee in attendees or []:
+			a = vCalAddress('mailto:' + attendee)
+			a.params['CN'] = vText(attendee)
+			a.params['PARTSTAT'] = vText('NEEDS-ACTION')
+			a.params['ROLE'] = vText('REQ-PARTICIPANT')
+			a.params['CUTYPE'] = vText('INDIVIDUAL')
+			e.add('attendee', a)
 
 		# let's check who we are...
 		i = 0
@@ -132,31 +142,33 @@ def schedule_event_sync(calendar_name: str, title: str, description: str, start_
 			raise Exception('Error fetching current user information')
 
 		# ...and set the organizer
-		e.organizer = Organizer(common_name=json['displayname'], email=json['email'])
+		organizer = vCalAddress('mailto:' + (json['email'] or ''))
+		organizer.params['CN'] = vText(json['displayname'])
+		e.add('organizer', organizer)
 
 		# Add event to calendar
-		c.events.add(e)
 
 		principal = ncSync.cal.principal()
 		calendars = principal.calendars()
 		calendar = {cal.name: cal for cal in calendars}[calendar_name]
-		calendar.add_event(str(c))
+		calendar.add_event(e.to_ical().decode())
 
 	@tool
 	@impulse(event_radius)
-	async def schedule_event(calendar_name: str, title: str, description: str, start_date: str, end_date: str, attendees: Optional[list[str]], start_time: Optional[str], end_time: Optional[str], location: Optional[str], timezone: Optional[str]):
+	async def schedule_event(calendar_name: str, title: str, description: str, start_date: str, end_date: str, attendees: Optional[list[str]] = None, start_time: Optional[str] = None, end_time: Optional[str] = None, location: Optional[str] = None, timezone: Optional[str] = None):
 		"""
 		Crete a new event or meeting in a calendar. Omit start_time and end_time parameters to create an all-day event.
 		:param calendar_name: The name of the calendar to add the event to
 		:param title: The title of the event
 		:param description: The description of the event
 		:param start_date: the start date of the event in the following form: YYYY-MM-DD e.g. '2024-12-01'
-		:param end_date: the end date of the event in the following form: YYYY-MM-DD e.g. '2024-12-01'
+		:param end_date: the last day of the event, inclusive: for a single-day event pass the
+			same date as start_date. Form: YYYY-MM-DD e.g. '2024-12-01'
 		:param attendees: the list of attendees to add to the event (as email addresses)
 		:param start_time: the start time in the following form: HH:MM AM/PM e.g. '3:00 PM'
 		:param end_time: the start time in the following form: HH:MM AM/PM e.g. '4:00 PM'
 		:param location: The location of the event
-		:param timezone: Timezone (e.g., 'America/New_York').
+		:param timezone: Timezone (e.g., 'America/New_York'). Defaults to the user's profile timezone. Must be a valid IANA timezone name.
 		:return: bool
 		"""
 		await asyncio.to_thread(schedule_event_sync, calendar_name, title, description, start_date, end_date, attendees, start_time, end_time, location, timezone)
@@ -240,8 +252,8 @@ async def find_free_time_slot_in_calendar(participants: list[str], slot_duration
 		available_slots = await asyncio.to_thread(find_free_time_slot_in_calendar_sync, participants, slot_duration, start_time, end_time)
 		return available_slots
 
-	def add_task_sync(calendar_name: str, title: str, description: str, due_date: Optional[str],
-					   due_time: Optional[str], timezone: Optional[str]):
+	def add_task_sync(calendar_name: str, title: str, description: str, due_date: Optional[str] = None,
+					   due_time: Optional[str] = None, timezone: Optional[str] = None):
 		description_with_ai_note = f"{description}\n\n---\n\nThis task was scheduled by Nextcloud AI Assistant."
 
 		# Create task
@@ -262,10 +274,9 @@ def add_task_sync(calendar_name: str, title: str, description: str, due_date: Op
 			else:
 				due_datetime = due_date
 
-			# Set timezone
-			if timezone != None:
-				tz = pytz.timezone(timezone)
-				due_datetime = tz.localize(due_datetime)
+			# Set timezone (defaults to the user's profile timezone)
+			timezone = timezone or user_timezone(ncSync)
+			due_datetime = pytz.timezone(get_timezone(timezone)).localize(due_datetime)
 
 			t.due = due_datetime
 
@@ -281,18 +292,17 @@ def add_task_sync(calendar_name: str, title: str, description: str, due_date: Op
 
 	@tool
 	@impulse(calendar_radius)
-	async def add_task(calendar_name: str, title: str, description: str, due_date: Optional[str], due_time: Optional[str], timezone: Optional[str]):
+	async def add_task(calendar_name: str, title: str, description: str, due_date: Optional[str] = None, due_time: Optional[str] = None, timezone: Optional[str] = None):
 		"""
 		Crete a new task in a calendar.
 		:param calendar_name: The name of the calendar to add the task to
 		:param title: The title of the task
 		:param description: The description of the task
 		:param due_date: the due date of the event in the following form: YYYY-MM-DD e.g. '2024-12-01'
 		:param due_time: the due time in the following form: HH:MM AM/PM e.g. '3:00 PM'
-		:param timezone: Timezone (e.g., 'America/New_York'). Is required if there is a specified due date.
+		:param timezone: Timezone (e.g., 'America/New_York'). Defaults to the user's profile timezone. Must be a valid IANA timezone name.
 		:return: bool
 		"""
-
 		await asyncio.to_thread(add_task_sync, calendar_name, title, description, due_date, due_time, timezone)
 
 		return True
@@ -387,7 +397,7 @@ async def complete_task(calendar_name: str, task_uid: str):
 		"""
 		return await asyncio.to_thread(complete_task_sync, calendar_name, task_uid)
 
-	def update_task_sync(calendar_name: str, task_uid: str, title: Optional[str] = None, description: Optional[str] = None, due_date: Optional[str] = None, due_time: Optional[str] = None, timezone_str: Optional[str] = None, priority: Optional[int] = None):
+	def update_task_sync(calendar_name: str, task_uid: str, title: Optional[str] = None, description: Optional[str] = None, due_date: Optional[str] = None, due_time: Optional[str] = None, priority: Optional[int] = None, timezone: Optional[str] = None):
 		principal = ncSync.cal.principal()
 		calendars = principal.calendars()
 		calendar = {cal.name: cal for cal in calendars}[calendar_name]
@@ -416,9 +426,8 @@ def update_task_sync(calendar_name: str, task_uid: str, title: Optional[str] = N
 							else:
 								due_datetime = parsed_date
 
-							if timezone_str:
-								tz = pytz.timezone(timezone_str)
-								due_datetime = tz.localize(due_datetime)
+							timezone = timezone or user_timezone(ncSync)
+							due_datetime = pytz.timezone(get_timezone(timezone)).localize(due_datetime)
 
 							ics_todo.due = due_datetime
 
@@ -433,7 +442,7 @@ def update_task_sync(calendar_name: str, task_uid: str, title: Optional[str] = N
 
 	@tool
 	@impulse(calendar_radius)
-	async def update_task(calendar_name: str, task_uid: str, title: Optional[str] = None, description: Optional[str] = None, due_date: Optional[str] = None, due_time: Optional[str] = None, timezone: Optional[str] = None, priority: Optional[int] = None):
+	async def update_task(calendar_name: str, task_uid: str, title: Optional[str] = None, description: Optional[str] = None, due_date: Optional[str] = None, due_time: Optional[str] = None, priority: Optional[int] = None, timezone: Optional[str] = None):
 		"""
 		Update an existing task
 		:param calendar_name: The name of the calendar containing the task (obtainable via list_calendars)
@@ -442,11 +451,11 @@ async def update_task(calendar_name: str, task_uid: str, title: Optional[str] =
 		:param description: New description for the task
 		:param due_date: New due date in the form: YYYY-MM-DD e.g. '2024-12-01'
 		:param due_time: New due time in the form: HH:MM AM/PM e.g. '3:00 PM'
-		:param timezone: Timezone (e.g., 'America/New_York')
 		:param priority: Priority from 0 (undefined) to 9 (lowest), where 1 is highest priority
+		:param timezone: Timezone (e.g., 'America/New_York'). Defaults to the user's profile timezone. Must be a valid IANA timezone name.
 		:return: bool indicating success
 		"""
-		return await asyncio.to_thread(update_task_sync, calendar_name, task_uid, title, description, due_date, due_time, timezone, priority)
+		return await asyncio.to_thread(update_task_sync, calendar_name, task_uid, title, description, due_date, due_time, priority, timezone)
 
 	def delete_task_sync(calendar_name: str, task_uid: str):
 		principal = ncSync.cal.principal()