Repository navigation
fix(dav): extend the lock expiry on a WebDAV LOCK refresh - #1361
Merged
benjaminfrueh merged 1 commit intoOct 15, 2026
Merged
Conversation
gazziiii777
requested review from
benjaminfrueh and
juliusknorr
as code owners
October 12, 2026 17:23
benjaminfrueh
left a comment
benjaminfrueh
left a comment
Contributor
There was a problem hiding this comment.
Thank you for opening this PR! Seems good to me, I left a small review.
Also in case this PR was AI assisted, please add the Assisted-by: AGENT_NAME:MODEL_VERSION trailer to the commit and disclose it in the PR description as described in our AI policy https://github.com/nextcloud/.github/blob/master/AI_POLICY.md
| * there produced the invalid "Second--60"; -60 and 0 are what | ||
| * LockService::lock() actually stores for the two "never expires" configs. | ||
| */ | ||
| /** |
Contributor
There was a problem hiding this comment.
The new test is inserted between testInfiniteLockReportsStandardWebdavTimeoutAsInfinite() and its docblock. Could you move it above line 359?
A refresh wrote the client's Timeout from the original LOCK instead of from the refresh, so a native WebDAV lock died after the first Timeout regardless of refreshes and every later PUT got 412. Add the elapsed time to the stored lifetime so the expiry moves out from the refresh. Fixes nextcloud#1343 Assisted-by: Claude Code:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: gazziiii777 <gazziiii777@gmail.com>
gazziiii777
force-pushed
the
fix/dav-lock-refresh-expiry
branch
from
October 15, 2026 09:14
9e8b256 to
0012f64
Compare
benjaminfrueh
approved these changes
Oct 15, 2026
Contributor
|
/backport to stable35 |
Contributor
|
/backport to stable34 |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refresh wrote the client's Timeout from the original LOCK instead of from the refresh, so a native WebDAV lock died after the first Timeout regardless of refreshes and every later PUT got 412. Add the elapsed time to the stored lifetime so the expiry moves out from the refresh.
Fixes #1343
AI disclosure: this PR was prepared with Claude Code (claude-fable-5-1). It found the cause in the code and wrote the fix and the test. I ran into the bug with users on my own Nextcloud server, applied the fix there and verified that saving from Excel over WebDAV no longer fails after an hour. The commit carries the Assisted-by trailer.