Repository navigation
[stable-0.1] fix(editor): wheel scrolling and zoom in Firefox, Shift+wheel and small zoom steps - #403
Merged
Conversation
The editor pans on the non-standard mousewheel event and zooms on it with Ctrl, but kity only listens for an event that elements have an on<type> property for, and Firefox has neither onmousewheel nor fires mousewheel. So wheel scrolling and Ctrl+wheel zoom did nothing in Firefox. Where mousewheel is missing, give elements the property and re-dispatch each wheel event as mousewheel with the deltas Chrome reports. Fixes #93 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> (cherry picked from commit 4b6c259)
AndyScherzinger
added
enhancement
…l steps The editor ignored the wheel while Shift was held, and zoomed with Ctrl or Cmd only once a single event reported more than 100, which touchpad pinches and the small pixel steps of macOS never do. Re-dispatch the wheel as mousewheel in Chrome too where needed: with Shift as horizontal scrolling, and with Ctrl or Cmd with at least 120. The editor still zooms once per gesture, as it waits for 100 ms of quiet. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> (cherry picked from commit cb780ce)
1 task done
AndyScherzinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #402 to
stable-0.1. Fixes #93 for Nextcloud 32–35.kityonly listens formousewheelwhen elements have anonmousewheelproperty, and Firefox has neither that property nor the event. The editor iframe's script now provides both, re-dispatching standardwheelevents with Chrome's deltas.Both commits cherry-picked without changes. Tested on Nextcloud 32 and 35 in Chromium and Firefox, with the same results as in #402:
🤖 AI (if applicable)