Repository navigation
Conversation
edward-ly
left a comment
There was a problem hiding this comment.
Hello, the way I see it, all of these use cases have existing workarounds or can be implemented in simpler ways.
advanced options - for a little bit more advanced users, who are able to write their own instructions for LLM
Why not just use the Assistant chat or the Generate text task instead, providing the "system prompt" and the user prompt in the same field? Separating them wouldn't provide much extra benefit and only confuses all users even more. Plus, overriding the system prompt means users could theoretically provide non-summary prompts in a summary task, which is clearly not the intention.
So those are field-specific summary tasks types. In general it is a summary, but based on the domain, the user might need different kind of information to be extracted.
An LLM might be able to extract these important parts already without the need for additional prompts. But even if it doesn't, you can still use the same workaround as before.
a user can set output format themselves for their needs
I would recommend adding these additional options to the Format input parameter instead. If users require any custom formatting, I would again point them to the same workaround as before.
Considering workaround: it works as long as the input fits a single request.
I agree with that. It can be decided by the admin - I can add an admin toggle to enable/disable user-defined prompts if needed.
Considering format: I think that adding tables, headings etc format is a good idea. My proposal was about formats that do not fit a fixed enum. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Sure, chunking might not make the most sense for chat, but other tasks such as
Hm, I think you can use the Also, now that #437 is merged, please rebase the branch, remove the extra commits from that PR, and resolve any additional conflicts too. |
Signed-off-by: Arkadiusz Sitkiewicz <a.sitkiewicz@wbgroup.com>
deee1ec to
945c8ce
Compare
I wasn't aware of that. In that case I agree that it is valid workaround and we don't need
Nice to hear that. For now I would not add formatting options just in case. If I run into a different formatting style that is general and I actually use I will open a follow-up PR for it.
Done ✅ Thanks for collaboration 😊 |
Appreciate it, but going back to the original question, then: what other use cases does this PR provide that isn't already covered? I'm not sure if I see a need to merge this at all otherwise. |
Ok, I looked at the code of Both providers send user's instructions together with a chunk
So there is a difference in generated final output:
The concrete example that I came up with is the case that we have a long transcript of a meeting and want a summarized version of it with fixed sections, for example: 1. Meeting purpose, 2 Attendants. 3. Deadlines. If the input is split into 3 chunks, the output will be
That's the case where a user-system-prompt for summary adds something over the |
User defined system prompt for summary task
Related work:
This PR is stacked on #437 :
Feel free to check #437, it describes the whole work for system prompts for different task types. It also provide a description of
User defined system prompt for summaryand presents UI look. Hierarchy is as follows:ComplexityandFormatoptions are ignored)ComplexityandFormatoptions are appended)@edward-ly asked to move the
user-defined system promptpart out of #437 and suggested to adduser-defined system promptpart in separate PR with justification.Justification for user defined system prompts
I agree with @edward-ly that it adds complexity for the user. The user has to know a little about how system prompts work for LLM and how to write instructions. On the other hand, this functionality is available after clicking
Show advanced optionsso we can split users into two group:Use cases and why admin prompt is not enough
Admin defined system prompt for summary is a good option but it has to be general, because it has to work for everyone.
User-defined system prompt gives a user more control. This control might be required for different type of text to summarize. For example:
So those are field-specific summary tasks types. In general it is a summary, but based on the domain, the user might need different kind of information to be extracted.
What is more, with
user defined system prompt for summarya user can set output format themselves for their needs:##headingsOutput formats can be mixed in summary if user defines that.
It all can be achieved with setting a good instruction for a model, but it is field/user specific instruction. Well written
admin system promptcan be a good fit for most cases, but for specific kind of field/workuser-defined system promptmight give better results if written correctly.I would really appreciate your thoughts on these use-cases. If you prefer a different approach I am happy to rework this.