Repository navigation
Set name extension to task processing file outputs - #450
Merged
Merged
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
enhancement
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
kyteinsky
approved these changes
Oct 27, 2026
Contributor
There was a problem hiding this comment.
nit: image_type_to_extension(getimagesizefromstring($data)[2], false) can return the extension as well, instead of doing it manually
marcelklehr
reviewed
Oct 27, 2026
| } | ||
| } | ||
| $result['output'] = $output; | ||
| $result['output'] = new FileShaped(EShapeType::Audio, $output, 'mp3'); |
Member
There was a problem hiding this comment.
Is this guaranteed to be an mp3? 🤔
Member
Author
There was a problem hiding this comment.
It's enforced as a request param. But some services might ignore this param indeed. Want to implement a type check?
Member
There was a problem hiding this comment.
Would be good i think, in case the service doesn't follow the param
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/output-file-ext
branch
from
October 27, 2026 14:17
db6b630 to
8795ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCP\TaskProcessing\FileShapedclass to return file outputs in some providers.🤖 AI (if applicable)