Repository navigation
fix: constructor property promotion follow-up - #161
Merged
Merged
Conversation
Finish the property modernization started in #158. Promote the remaining IDBConnection and IConfig deps in NotifyUnsetPassword to readonly promoted constructor params, drop the legacy @var docblocks and manual assignments, and add readonly to the already-promoted props in ExpireUnverifiedAccounts for consistency with the rest of the app. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Replace the 'preferred_providers' string literals scattered across the background jobs, settings, controller and templates with the existing Application::APP_ID constant, so the app id is hardcoded in a single place. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
The trait referenced $this->appName, which no longer exists on ExpireUnverifiedAccounts after dropping the property. Use the Application::APP_ID constant directly instead. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
enabled auto-merge
July 1, 2026 17:14
skjnldsv
changed the title
skjnldsv
disabled auto-merge
July 2, 2026 08:32
skjnldsv
added a commit
that referenced
this pull request
Jul 2, 2026
The property-promotion cleanup (#161) migrated ExpireUserTrait and ExpireUnverifiedAccounts off the removed $appName property to Application::APP_ID, but missed the pp_disabled line added by the reactivation feature. Left as $this->appName it referenced an undefined property, so the expire background job fatally errored at runtime (and psalm/phpunit flagged it). Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #158, addresses Carl's review comment: the constructor property promotion was only half done in the two background job classes.
Also fixed the multiple app id consts 🤷
Developed with AI assistance (Claude Code,
claude-opus-4-8), disclosed per the AI Contribution Policy. Reviewed and tested; I take authorship.