Repository navigation
Add Team Activity resource provider and TeamFolder root fi… #65347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hefftich
wants to merge
1
commit into
master
Choose a base branch
from
feat/team-activity-resource-provider
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCP\Teams; | ||
|
|
||
| use OCP\AppFramework\Attribute\Implementable; | ||
|
|
||
| /** | ||
| * An optional Team resource provider capability for Team Activity. | ||
| * | ||
| * @since 36.0.0 | ||
| */ | ||
| #[Implementable(since: '36.0.0')] | ||
| interface ITeamActivityResourceProvider extends ITeamResourceProvider { | ||
| /** | ||
| * Resolve Team resources into Activity objects visible to the current user. | ||
| * | ||
| * @param list<TeamResource> $resources Resources from this provider shared with the Team | ||
| * @param string $userId The user the activity scopes are resolved for | ||
| * @return list<TeamActivityScope> | ||
| * @since 36.0.0 | ||
| */ | ||
| public function getActivityScopes(array $resources, string $userId): array; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCP\Teams; | ||
|
|
||
| use OCP\AppFramework\Attribute\Consumable; | ||
|
|
||
| /** | ||
| * A set of Activity objects belonging to Team resources. | ||
| * | ||
| * @since 36.0.0 | ||
| */ | ||
|
hefftich marked this conversation as resolved.
|
||
| #[Consumable(since: '36.0.0')] | ||
| final readonly class TeamActivityScope { | ||
| /** @var list<positive-int> */ | ||
| private array $objectIds; | ||
|
|
||
| /** | ||
| * @param list<positive-int> $objectIds | ||
| * @param non-empty-string $objectType | ||
| * @since 36.0.0 | ||
| */ | ||
| public function __construct( | ||
| private string $objectType, | ||
| array $objectIds, | ||
| ) { | ||
| $this->objectIds = array_values(array_unique($objectIds)); | ||
| } | ||
|
|
||
| /** | ||
| * @return non-empty-string | ||
| * @since 36.0.0 | ||
| */ | ||
| public function getObjectType(): string { | ||
| return $this->objectType; | ||
| } | ||
|
|
||
| /** | ||
| * @return list<positive-int> | ||
| * @since 36.0.0 | ||
| */ | ||
| public function getObjectIds(): array { | ||
| return $this->objectIds; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace Test\Teams; | ||
|
|
||
| use OCP\AppFramework\Attribute\Consumable; | ||
| use OCP\AppFramework\Attribute\Implementable; | ||
| use OCP\Teams\ITeamActivityResourceProvider; | ||
| use OCP\Teams\TeamActivityScope; | ||
| use Test\TestCase; | ||
|
|
||
| class TeamActivityScopeTest extends TestCase { | ||
| public function testGettersReturnConstructorValues(): void { | ||
| $scope = new TeamActivityScope('files', [1, 2, 3]); | ||
|
|
||
| $this->assertSame('files', $scope->getObjectType()); | ||
| $this->assertSame([1, 2, 3], $scope->getObjectIds()); | ||
| } | ||
|
|
||
| public function testDeduplicatesObjectIds(): void { | ||
| $scope = new TeamActivityScope('files', [1, 2, 2, 3, 1]); | ||
|
|
||
| $this->assertSame([1, 2, 3], $scope->getObjectIds()); | ||
| } | ||
|
|
||
| public function testAllowsEmptyObjectIds(): void { | ||
| $scope = new TeamActivityScope('files', []); | ||
|
|
||
| $this->assertSame([], $scope->getObjectIds()); | ||
| } | ||
|
|
||
| public function testReturnedObjectIdsDoNotMutateScope(): void { | ||
| $scope = new TeamActivityScope('files', [1, 2, 3]); | ||
| $objectIds = $scope->getObjectIds(); | ||
| $objectIds[] = 4; | ||
|
|
||
| $this->assertSame([1, 2, 3], $scope->getObjectIds()); | ||
| } | ||
|
|
||
| public function testScopeIsFinalAndReadonly(): void { | ||
| $class = new \ReflectionClass(TeamActivityScope::class); | ||
|
|
||
| $this->assertTrue($class->isFinal()); | ||
| $this->assertTrue($class->isReadOnly()); | ||
| } | ||
|
|
||
| public function testScopeIsConsumable(): void { | ||
| $class = new \ReflectionClass(TeamActivityScope::class); | ||
| $attributes = $class->getAttributes(Consumable::class); | ||
|
|
||
| $this->assertCount(1, $attributes); | ||
| $this->assertSame('36.0.0', $attributes[0]->newInstance()->getSince()); | ||
| } | ||
|
|
||
| public function testProviderIsImplementable(): void { | ||
| $class = new \ReflectionClass(ITeamActivityResourceProvider::class); | ||
| $attributes = $class->getAttributes(Implementable::class); | ||
|
|
||
| $this->assertCount(1, $attributes); | ||
| $this->assertSame('36.0.0', $attributes[0]->newInstance()->getSince()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.