[MarioPym]

Summary

An app password can be renamed to an empty or whitespace-only name: the request returns 200 and the token is saved without a visible name in the list. On creation, an empty name is already rejected, but a whitespace-only name is accepted.

update() now returns 400 when the new name is empty after trimming, before anything is changed, so the frontend shows its existing error and restores the previous name. Tokens that already have an empty name can still change their filesystem scope, since the check only applies when the name changes. create() now also treats a whitespace-only name as empty and keeps the existing 503 response.

How to test

1. Go to Personal settings → Security → Devices & sessions and create an app password
2. Rename it to an empty name or to a few spaces
3. Before: the request returns 200 and the name is saved blank. After: it returns 400, an error is shown and the previous name is kept

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[MarioPym]

Rebased onto master to resolve the conflict with the TokenScopes changes in update(). The fix itself is unchanged.

[come-nc]

Shouldn’t we trim the name at the beginning then, to forbid confusing spaces at start&end ?

[MarioPym]

Shouldn’t we trim the name at the beginning then, to forbid confusing spaces at start&end ?

Good point, done. The name is now trimmed on create and on rename. On update it's only trimmed when the name actually changes, so existing tokens whose names already have surrounding spaces aren't renamed when only the scope is changed.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[susnux]

@MarioPym please rebase

[MarioPym]

Rebased onto master, thanks!

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22