chore: Add pre-commit hook to make sure to not push updater.phar with a dirty version#768
Open
come-nc wants to merge 2 commits into
Open
chore: Add pre-commit hook to make sure to not push updater.phar with a dirty version#768come-nc wants to merge 2 commits into
come-nc wants to merge 2 commits into
Conversation
… a dirty version When git status is not clean "dirty" gets added in lib/Version.php and that makes the check-same-code check to fail on updater.phar This adds a pre-commit hook to detect that locally before pushing. Also added php-lint and cs-fixer hooks. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Collaborator
Author
|
#757 may be a better alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When git status is not clean "dirty" gets added in lib/Version.php and
that makes the check-same-code check to fail on updater.phar
This adds a pre-commit hook to detect that locally before pushing. Also added php-lint and cs-fixer hooks.