Skip to content

[master] 2003-General_Settings_Dialog #384

Open
memurats wants to merge 15 commits into
masterfrom
nmc/master/general_settings_dialog
Open

[master] 2003-General_Settings_Dialog #384
memurats wants to merge 15 commits into
masterfrom
nmc/master/general_settings_dialog

Conversation

@memurats
Copy link
Copy Markdown

@memurats memurats commented Oct 27, 2025

general settings dialog changes

@memurats memurats self-assigned this Oct 27, 2025
@memurats memurats added custom MagentaCLOUD customisation approved build-ready Include into custom client build labels Oct 27, 2025
@github-actions github-actions Bot mentioned this pull request Oct 27, 2025
Closed
github-actions Bot pushed a commit that referenced this pull request Oct 28, 2025
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
310148b
@memurats memurats force-pushed the nmc/master/general_settings_dialog branch from 1f83cf6 to f4fb19f Compare November 14, 2025 13:07
@memurats memurats added the enhancement New feature or request label Jan 22, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 22, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
b0c93ae
github-actions Bot pushed a commit that referenced this pull request Jan 22, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
3916604
github-actions Bot pushed a commit that referenced this pull request Jan 23, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
c0a735e
@memurats memurats removed the enhancement New feature or request label Jan 23, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 23, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
0508a12
@memurats memurats added the enhancement New feature or request label Jan 26, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 26, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
666682d
@memurats memurats force-pushed the nmc/master/general_settings_dialog branch from a81a36a to 4fad719 Compare January 26, 2026 09:56
@memurats memurats removed the enhancement New feature or request label Feb 4, 2026
github-actions Bot pushed a commit that referenced this pull request Feb 4, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
c33f0c6
@memurats memurats added approved build-ready Include into custom client build and removed approved build-ready Include into custom client build labels Feb 13, 2026
@github-actions github-actions Bot force-pushed the nmc/master/general_settings_dialog branch from 66188c9 to 1b12b23 Compare February 13, 2026 12:55
@github-actions github-actions Bot force-pushed the nmc/master/general_settings_dialog branch from 1b12b23 to 66cdf3c Compare February 24, 2026 12:07
github-actions Bot pushed a commit that referenced this pull request Feb 24, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
db6e37d
@memurats memurats added the enhancement New feature or request label Feb 24, 2026
github-actions Bot pushed a commit that referenced this pull request Feb 24, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
dd19e85
github-actions Bot pushed a commit that referenced this pull request Feb 24, 2026
@memurats
Merge #384 [master] 2003-General_Settings_Dialog
da700a6
@github-actions github-actions Bot mentioned this pull request Feb 24, 2026
Open
@Rello Rello requested a review from i2h3 as a code owner March 20, 2026 10:06
@Rello Rello added the approved label Mar 20, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 20, 2026

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Rello
Copy link
Copy Markdown
Collaborator

Rello commented Mar 20, 2026

/Volumes/builds/38024/macos-38024/src/gui/nmcgui/nmcgeneralsettings.cpp
/Volumes/builds/38024/macos-38024/src/gui/nmcgui/nmcgeneralsettings.cpp:50:14: error: no member named 'groupBox' in 'OCC::Ui::GeneralSettings'
50 | getUi()->groupBox->setVisible(false);
| ~~~~~~~ ^
1 error generated.

the nmc general settings do not fit the new structure anymore. needs to be reworked

@Rello Rello removed the approved label Mar 20, 2026
@memurats memurats force-pushed the nmc/master/general_settings_dialog branch from defd874 to 12781d9 Compare April 28, 2026 13:17
@memurats memurats requested a review from nilsding as a code owner April 28, 2026 13:17
@memurats memurats force-pushed the nmc/master/general_settings_dialog branch from 12781d9 to 0caae8c Compare May 26, 2026 08:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 26, 2026

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions Bot mentioned this pull request May 26, 2026
Open
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

@memurats memurats

Labels

approved build-ready Include into custom client build custom MagentaCLOUD customisation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@memurats @Rello @tsdicloud