Repository navigation
Fix desktop startup project-loading crash - #283
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memex could abort during startup when project loading was cancelled and replaced while peer requests were still completing. The reproduced crash reached
__cxa_pure_virtualfromAsyncTask::completeFutureafter the project task group had been destroyed.Replace that group with explicitly owned workers and an
AsyncStreamfor completion-order updates. Cancellation reaches every worker, and the loader waits for all workers before returning. Existing cache retention and generation checks continue to protect against stale results. Add a regression covering cancellation with a pending peer.Validation:
cargo fmt --checkandmbx clippy -- -D warningspassed.