Skip to content

Fix desktop startup project-loading crash - #283

Merged
nicosuave merged 1 commit into
mainfrom
codex/fix-desktop-crash
Nov 10, 2026
Merged

nicosuave merged 1 commit into
mainfrom
codex/fix-desktop-crash

Conversation

@nicosuave

Copy link
Copy Markdown
Owner

Memex could abort during startup when project loading was cancelled and replaced while peer requests were still completing. The reproduced crash reached __cxa_pure_virtual from AsyncTask::completeFuture after the project task group had been destroyed.

Replace that group with explicitly owned workers and an AsyncStream for completion-order updates. Cancellation reaches every worker, and the loader waits for all workers before returning. Existing cache retention and generation checks continue to protect against stale results. Add a regression covering cancellation with a pending peer.

Validation:

@nicosuave
nicosuave merged commit 879bae7 into main Nov 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant