handle nested TBB in thread-safe fashion#188
Open
paciorek wants to merge 10 commits into
Open
Conversation
…ts are contained in private, and packaged names can be managed (#125) * initial redesign of nClass to hold a private Cpublic_obj and use it by active bindings * Add basic nClass_uncompiled tests * major work towards redesigning nClass generation and hierarchy * fix C++ handling (Exporter and generic interface set) of new nClass structure * close to finished with updated class naming issues within packages * updated tests after new packingNames and nCompile naming schemes * update predefineds. fix nimbleModels. fix package class generation with R fields. * fix StridedTensorMap operator() for single index * fix cpp_tests crash * test trials * give each case in test-argumentPassing unique package naming * Fix test-tensorCreation for old style
when creating packages (issue #127)
in cppDef processing, not via Rcpp plugin.
Put counting into class constructor/destructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of PR #178.
It uses a small custom class whose constructor/destructor handle the depth counting.
I believe this is in good shape, but want to check with @perrydv about the location of the class definition. I put it in
nCompiler_omnibus.hbehind an include guard to deal with the multiple definition problem.Per our conversation, I tried to add it to the R interface stuff defined in
global_R_interface_cppDef$cppContent. However that caused the following problems:nCompile, the class code was inserted at the bottom of thenCompiler_units.cppfile in which the class was used. The compiler complained about not being able to find the class definition.writePackage, the class code was inserted in the R_interface...cpp file, and again it was not found during compilation.We can discuss in person.
Once this is merged in, I'd like to move forward soon with merging
tbbintomain.