Repository navigation
Conversation
- Drop electron, electron-builder, concurrently and wait-on, the "main" field, electron:* scripts and the electron-builder "build" block, the electron/ directory and build/entitlements.mac.plist; clean the matching Dockerfile ENV, .dockerignore/.gitignore/eslint ignores and README text. - Remove the titlebar-drag/no-drag CSS and classes. The layout's sticky Electron drag spacer becomes pt-8 on the content wrapper, so pages keep the same top offset and Monitor's 100vh-2rem cap still fits. - vitest ^2.1.9 -> ^5 (vite 8); @types/node ^20 -> ^22 to satisfy its peer range and match the Node 22 runtime. vitest config uses import.meta.dirname instead of __dirname (vite native-loader warning). - test:edge now runs `node --test` from edge/: passing a directory to `node --test` only worked on Node 20 and fails on Node 22. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The product is the Docker hub + a browser; the
electron/shell was already retired in the README. This removes it and brings the test toolchain current. Split out of the credit-tracking work on purpose.electron,electron-builder,concurrently,wait-on; themainfield,electron:*scripts and the electron-builderbuildblock;electron/andbuild/entitlements.mac.plist. Also the DockerfileELECTRON_SKIP_BINARY_DOWNLOAD, the.dockerignore/.gitignore/ eslint ignores, stale comments, and the README mentions. The lockfile drops about 5.3k lines; the Dockernpm cistep now takes about 15s..titlebar-drag/.titlebar-no-dragCSS and its uses on the Dashboard, Monitor, Analytics and Settings pages. The layout's sticky, transparenth-8drag spacer had az-50layer, so it covered the top 2rem of scrolled content in the browser. It's nowpt-8on the content wrapper. Headers keep the same 40px offset, and Monitor's100vh-2remcap still fits (checked in the dev server).vitest.config.mtsnow usesimport.meta.dirnamebecause vite 8 warns about__dirname.@types/nodegoes from ^20 to ^22 to satisfy vitest 5's peer range and match the Node 22 runtime (CI and Docker).test:edgefix (pre-existing):node --test edge/test/fails on Node 22, because positional args became globs and a directory no longer expands. It now runsnpm --prefix edge test→node --test(auto-discovery), which works on both Node 20 (edgeengines) and Node 22+.App dependencies are unchanged in the lockfile: next 16.1.6, react 19.2.3, better-sqlite3, swr, eslint and typescript stay at their versions.
Test plan
npx tsc --noEmitnpm run lintnpm test: 194/194 on vitest 5.0.5, no warningsnpm run test:edge: 85 pass (84 tests plus the helpers module, which auto-discovery counts)npm run buildin a clean checkout. In a.claude/worktrees/*checkout, Next infers the parent repo's lockfile as workspace root and nests the standalone output, which breakspostbuild. That's environmental and the same on main.docker build .succeeds🤖 Generated with Claude Code