fix(a11y): WCAG 2.2 AA remediation across 9 elements#47
Merged
Conversation
- validate: add aria-invalid on fields, aria-live on error messages - virtual-list: add role=listbox/option, keyboard nav (Arrow/Home/End) - dnd: replace deprecated aria-grabbed with aria-roledescription, add live-region screen reader announcements, role=button on draggables - table sort: add tabindex=0 and Enter/Space keyboard activation - table reorder: replace aria-grabbed with aria-roledescription - accordion: add aria-expanded, aria-controls, role=region on panels - popover: add role=dialog (respecting existing roles), aria-haspopup=dialog - toast/stepper: already WCAG-compliant, no changes needed - Update tests to match new ARIA attributes
ErickXavier
force-pushed
the
fix/a11y-wcag
branch
from
72a87b1 to
91bd7de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-invalidon fields when validation fails,aria-live="polite"on error message containersrole="listbox"on container,role="option"+aria-setsize/aria-posinseton items, keyboard navigation (ArrowUp/Down/Home/End)aria-grabbedwitharia-roledescription="draggable item", addrole="button", create live-region for screen reader announcements (grab/drop/cancel/reorder)tabindex="0"on sortable headers, Enter/Space keyboard activation (WCAG 2.1.1)aria-grabbedwitharia-roledescription="draggable row"[aria-grabbed="true"]to.nojs-draggingaria-expanded+aria-controlson summary,role="region"on content panelsrole="dialog"(only when no existing role),aria-haspopup="dialog"on triggersTest plan
npm test— 498 passed, 5 skipped, 0 failuresnpm run build— dist/ files includedcd e2e && npx playwright test)