feat(docs): enable path-based SPA routing via 404.html#48
Merged
Conversation
Switch the Elements docs site from hash-based to path-based SPA routing to match the Core site (no-js.dev). Adds <base href="/">, sets useHash: false, updates syncSidebar/syncPrevNext to use location.pathname and popstate, and creates 404.html as a copy of index.html for the GitHub Pages deep-link fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<base href="/">for correct relative URL resolution on deep pathsuseHash: falsein the NoJS router configsyncSidebar()andsyncPrevNext()JS helpers to uselocation.pathnameandpopstateinstead oflocation.hashandhashchangehref="#/path"tohref="/path"docs/404.htmlas a byte-for-byte copy ofdocs/index.htmlfor GitHub Pages deep-link fallbackTest plan
/)/accordion) and verify the page renders