module: support 'module.exports' interop export name in require(esm)#54563
Closed
guybedford wants to merge 1 commit into
Closed
module: support 'module.exports' interop export name in require(esm)#54563guybedford wants to merge 1 commit into
guybedford wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
export { foo as 'module.exports' }in a CJS module to imply that this export value should always be used as the module value when requiring that ESM module underrequire(esm), allowing other types than just module namespaces in this interop.This effectively splits off the non-major change from #53848 as discussed in the Node.js loaders meeting, under a rename of this flag to use the
'module.exports'pattern, where that PR will be updated to use the name that lands here on the ESM wrapper as a major change further.The naming bikeshed took place in nodejs/loaders#221 and was determined by TSC vote.
//cc @nodejs/loaders