src,tools: enable BoringSSL in test-shared.yml#63206
Open
panva wants to merge 2 commits intonodejs:mainfrom
Open
src,tools: enable BoringSSL in test-shared.yml#63206panva wants to merge 2 commits intonodejs:mainfrom
panva wants to merge 2 commits intonodejs:mainfrom
Conversation
BoringSSL declares EVP_CIPHER_do_all_sorted and EVP_MD_do_all_sorted, but stock no-decrepit builds do not provide those symbols. Add a Node build flag that keeps ncrypto and its dependents on a local BoringSSL fallback list when libdecrepit is absent. Keep embedders that provide the EVP enumeration symbols on the normal OpenSSL-compatible path, matching Electron's patched BoringSSL build. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
the
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
panva
added
crypto
anonrig
approved these changes
May 8, 2026
Member
Author
|
🎉
|
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
May 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63206 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 713 713
Lines 224950 224950
Branches 42532 42532
==========================================
- Hits 202542 202529 -13
- Misses 14175 14181 +6
- Partials 8233 8240 +7
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
This means that, barring arm test skips in test *.status files hiding BoringSSL failures (and yes i fixed those earlier), embedders such as electron who use BoringSSL will not need to skip test suites, or at least not because we didn't account for BoringSSL.
This does not add algorithm implementation fallbacks for BoringSSL, that'll come next.
Footnotes
electron does not use nodejs/ncrypto, hence electron doesn't set
NCRYPTO_BSSL_LIBDECREPIT_MISSINGwhich means the fallback isn't in place and their boringssl w/ libdecrepit kicks in ↩nodejs/ncrypto builds define NCRYPTO_BSSL_LIBDECREPIT_MISSING which means when missing our fallback kicks in, if present libdecrepit takes over ↩