Skip to content

Commit 6dc769b

Browse files
committed
fix: remove unused repoInfo param and exclude pages from codecov
- Remove unused repoInfo parameter from PackageMarkdownOptions interface - Exclude app/pages and app/layouts from codecov patch coverage (these are tested by Playwright browser tests, not unit tests)
1 parent fc6d7ea commit 6dc769b

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

codecov.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ coverage:
77
default:
88
informational: true
99

10+
# Ignore files that are covered by browser tests (Playwright) rather than unit tests
11+
ignore:
12+
- 'app/pages/**/*'
13+
- 'app/layouts/**/*'
14+
1015
comment:
1116
layout: 'reach,diff,flags,tree,components,tests,build'
1217
behavior: default

server/utils/markdown.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import type { Packument, PackumentVersion } from '#shared/types'
2-
import type { RepositoryInfo } from '#shared/utils/git-providers'
32
import { joinURL } from 'ufo'
43

54
const SPARKLINE_CHARS = [' ', '▁', '▂', '▃', '▄', '▅', '▆', '▇', '█'] as const
@@ -126,19 +125,10 @@ export interface PackageMarkdownOptions {
126125
weeklyDownloads?: number
127126
dailyDownloads?: Array<{ day: string; downloads: number }>
128127
installSize?: number
129-
repoInfo?: RepositoryInfo
130128
}
131129

132130
export function generatePackageMarkdown(options: PackageMarkdownOptions): string {
133-
const {
134-
pkg,
135-
version,
136-
readme,
137-
weeklyDownloads,
138-
dailyDownloads,
139-
installSize,
140-
repoInfo: _repoInfo,
141-
} = options
131+
const { pkg, version, readme, weeklyDownloads, dailyDownloads, installSize } = options
142132

143133
const lines: string[] = []
144134

0 commit comments

Comments
 (0)