Skip to content

Commit 8583bd3

Browse files
committed
Merge remote-tracking branch 'origin/main' into fetch-readme-parallel
2 parents 8226686 + 57687cc commit 8583bd3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+3716
-570
lines changed
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
name: remove-needs-review-on-review
2+
3+
on:
4+
pull_request_review:
5+
types:
6+
- submitted
7+
8+
jobs:
9+
remove-needs-review:
10+
name: 🏷️ Remove needs review label
11+
if: github.repository == 'npmx-dev/npmx.dev'
12+
runs-on: ubuntu-slim
13+
permissions:
14+
contents: read
15+
issues: write
16+
pull-requests: write
17+
steps:
18+
- name: 🏷️ Remove needs review label
19+
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
20+
with:
21+
script: |
22+
const pr = context.payload.pull_request;
23+
const review = context.payload.review;
24+
const LABEL = 'needs review';
25+
const reviewer = review?.user?.login;
26+
const author = pr.user?.login;
27+
const reviewerType = review?.user?.type;
28+
29+
if (!reviewer) {
30+
console.log('No reviewer login found in payload, skipping.');
31+
return;
32+
}
33+
34+
if (reviewerType === 'Bot') {
35+
console.log(`Skipping bot review from @${reviewer} on PR #${pr.number}.`);
36+
return;
37+
}
38+
39+
if (reviewer === author) {
40+
console.log(`Skipping self-review from @${reviewer} on PR #${pr.number}.`);
41+
return;
42+
}
43+
44+
if (!pr.labels.some(({ name }) => name === LABEL)) {
45+
console.log(`PR #${pr.number} does not have the "${LABEL}" label.`);
46+
return;
47+
}
48+
49+
const { data: permission } = await github.rest.repos.getCollaboratorPermissionLevel({
50+
owner: context.repo.owner,
51+
repo: context.repo.repo,
52+
username: reviewer,
53+
});
54+
55+
console.log(`Reviewer @${reviewer} permission is "${permission.permission}".`);
56+
57+
if (!['admin', 'maintain', 'write'].includes(permission.permission)) {
58+
console.log(`Reviewer @${reviewer} is not a maintainer, skipping.`);
59+
return;
60+
}
61+
62+
await github.rest.issues.removeLabel({
63+
owner: context.repo.owner,
64+
repo: context.repo.repo,
65+
issue_number: pr.number,
66+
name: LABEL,
67+
});
68+
69+
console.log(`Removed "${LABEL}" from PR #${pr.number}.`);

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ What npmx offers:
7777
| Organization pages |||
7878
| Provenance indicators |||
7979
| Code browser |||
80-
| Dark mode | ||
80+
| Dark mode | ||
8181
| Outdated dependency warnings |||
8282
| Module format badges (ESM/CJS) |||
8383
| TypeScript types indicator |||

app/components/CollapsibleSection.vue

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,13 @@ function toggle() {
6262
}
6363
6464
const ariaLabel = computed(() => {
65-
const action = isOpen.value ? 'Collapse' : 'Expand'
66-
return props.title ? `${action} ${props.title}` : action
65+
if (!props.title) {
66+
return isOpen.value ? $t('common.collapse') : $t('common.expand')
67+
}
68+
69+
return isOpen.value
70+
? $t('common.collapse_with_name', { name: props.title })
71+
: $t('common.expand_with_name', { name: props.title })
6772
})
6873
useHead({
6974
style: [

app/components/ColorScheme/Img.vue

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<script setup lang="ts">
2+
const props = defineProps<{
3+
lightSrc: string
4+
darkSrc: string
5+
}>()
6+
</script>
7+
8+
<template>
9+
<img
10+
:src="props.darkSrc"
11+
class="color-mode-img"
12+
:style="`--light-src: url('${props.lightSrc}')`"
13+
/>
14+
</template>
15+
16+
<style>
17+
.light .color-mode-img {
18+
content: var(--light-src);
19+
}
20+
</style>

app/components/Compare/FacetBarChart.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ const config = computed<VueUiHorizontalBarConfig>(() => {
196196
},
197197
nameLabels: {
198198
fontSize: isMobile.value ? 12 : 18,
199-
color: colors.value.fgSubtle,
199+
color: colors.value.fg,
200200
},
201201
underlayerColor: colors.value.bg,
202202
},

0 commit comments

Comments
 (0)