Skip to content

feat: navigate to package code view on "dot" key#100

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
jhroemer:feat-package-code-view-opens-with-dot
Jan 26, 2026
Merged

feat: navigate to package code view on "dot" key#100
danielroe merged 5 commits intonpmx-dev:mainfrom
jhroemer:feat-package-code-view-opens-with-dot

Conversation

@jhroemer
Copy link
Copy Markdown
Contributor

Uses same styling as the search / element, only difference is I resized to 4 w/h like the other inline icons (looks nicer also). This version also hides the icon on mobile - again similar to /.

I'm not too familiar with Vue, but as far as I understand VueUse is very standard, and already installed in the project. Let me know if there's something I need to change though.

Screenshot 2026-01-26 at 06 49 09

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 26, 2026

@jhroemer is attempting to deploy a commit to the danielroe Team on Vercel.

A member of the Team first needs to authorize it.

@patak-cat patak-cat changed the title Feat: navigate to package code view on "dot" key feat: navigate to package code view on "dot" key Jan 26, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 26, 2026 9:38am

Request Review

@danielroe
Copy link
Copy Markdown
Member

this is great! added aria-keyshortcuts which we should also have used in the header

and dropped the icon as it felt a bit much - but happy to revisit if folk think it should have an icon too

@danielroe danielroe merged commit 5f2316a into npmx-dev:main Jan 26, 2026
8 checks passed
@jhroemer
Copy link
Copy Markdown
Contributor Author

this is great! added aria-keyshortcuts which we should also have used in the header

Yes, awesome! Thanks!

and dropped the icon as it felt a bit much - but happy to revisit if folk think it should have an icon too

Very good call, it's one thing I was unsure of regarding the change and adding the keyboard shortcut icon. My general stance on keyboard shortcuts in web apps is the same as with TUI's, they should be discoverable directly in the UI with minimal effort. So I think the keyboard shortcut icon is really needed, unless we use a tooltip to show info.

vinnymac pushed a commit to vinnymac/npmx.dev that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants