feat: navigate to package code view on "dot" key#100
feat: navigate to package code view on "dot" key#100danielroe merged 5 commits intonpmx-dev:mainfrom
Conversation
|
@jhroemer is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
this is great! added and dropped the icon as it felt a bit much - but happy to revisit if folk think it should have an icon too |
Yes, awesome! Thanks!
Very good call, it's one thing I was unsure of regarding the change and adding the keyboard shortcut icon. My general stance on keyboard shortcuts in web apps is the same as with TUI's, they should be discoverable directly in the UI with minimal effort. So I think the keyboard shortcut icon is really needed, unless we use a tooltip to show info. |
Uses same styling as the search
/element, only difference is I resized to 4 w/h like the other inline icons (looks nicer also). This version also hides the icon on mobile - again similar to/.I'm not too familiar with Vue, but as far as I understand VueUse is very standard, and already installed in the project. Let me know if there's something I need to change though.