Skip to content

chore: add missing connect to npm cli option in mobile version#1002

Closed
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:chore/add-missing-option
Closed

chore: add missing connect to npm cli option in mobile version#1002
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:chore/add-missing-option

Conversation

@iiio2
Copy link
Copy Markdown
Contributor

@iiio2 iiio2 commented Feb 5, 2026

currently add to npm cli is missing in mobile version. I think maybe we can add this.

clin

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 8:52am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 8:52am
npmx-lunaria Ignored Ignored Feb 5, 2026 8:52am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Header/MobileMenu.client.vue 42.85% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the MobileMenu.client.vue component to enhance connection state handling in the Account section. The useConnector() hook return type is updated to include an isConnecting boolean property alongside existing properties. A conditional UI block is introduced to display a "Connect npm CLI" button when no npm user is connected, featuring a spinner during the connection process. The existing connected npm user block remains functional, with its rendering now controlled by the updated state conditions.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description directly addresses the changeset by explaining the motivation to add the missing 'Connect to npm CLI' option in the mobile version, with supporting visual evidence.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe
Copy link
Copy Markdown
Member

this is deliberate as you are unlikely to have the npm cli installed on your phone

@wojtekmaj
Copy link
Copy Markdown
Contributor

this is deliberate as you are unlikely to have the npm cli installed on your phone

@danielroe danielroe closed this Feb 5, 2026
@iiio2
Copy link
Copy Markdown
Contributor Author

iiio2 commented Feb 5, 2026

Oh I see, Thanks.

@iiio2 iiio2 deleted the chore/add-missing-option branch February 5, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants